chore: remove ssh-keyscan as it shouldn't be necessary

[AtofStryker]

• Closes

Additional details

Currently, our windows builds are failing with this error:

due to this issue PowerShell/Win32-OpenSSH#2140

The reason it was introduced in the first place to our CI is we run the stable tag for windows-server-2022-gui, which just recently bumped from 2024.04.1 to 2024.12.1, which includes a newer version Open SSH for Windows.

To mitigate this, I think we can just remove the ssh-keyscan method from our CI job as the checkout job should have updated keys. My guess is we used this to patch around some previous checkout issues and I would like to try and remove it first and see if any issues creep up in the future as opposed to possibility maintaining something we likely no longer need.

Steps to test

How has the user experience changed?

PR Tasks

• Have tests been added/updated?
• Has a PR for user-facing changes been opened in cypress-documentation?
• Have API changes been updated in the type definitions?

---

Note

Removes the ssh-keyscan step and switches branch filters/conditions to chore/fix_builds in CircleCI configs.

• CI (CircleCI):
  • Remove update_known_hosts step from node_modules_install (drops ssh-keyscan usage).
  • Update setup_should_persist_artifacts branch condition to use chore/fix_builds instead of ryanm/fix/rename-exclude-from-ai.
  • Adjust workflow branch filters in workflows/@main.yml to include chore/fix_builds and remove the old branch.

^{Written by Cursor Bugbot for commit b36e218. This will update automatically on new commits. Configure here.}

[cypress]

cypress    Run #66815

Run Properties:   Failed #66815  •  b36e218215: remove update known hosts from original checkout as its a deep checkout

Project	cypress
Branch Review	chore/fix_builds
Run status	Failed #66815
Run duration	22m 22s
Commit	b36e218215: remove update known hosts from original checkout as its a deep checkout
Committer	Bill Glesias
View all properties for this run ↗︎

---

Test results
Failures	5
Flaky	3
Pending	28
Skipped	0
Passing	789
View all changes introduced in this branch ↗︎

UI Coverage  62.34%
Untested elements	27
Tested elements	48

Accessibility  99.03%
Failed rules	0 critical   3 serious   1 moderate   0 minor
Failed elements	19

---

Tests for review

  cypress\e2e\runner\retries.experimentalRetries.mochaEvents.cy.ts • 1 failed test • app-e2e

View Output

Test		Artifacts
... > does not try to serialize error with err.actual as DOM node		Test Replay Screenshots

  cypress\e2e\runner\runner.ui.cy.ts • 3 failed tests • app-e2e

View Output

Test		Artifacts
src/cypress/runner > tests finish with correct state > no tests		Test Replay Screenshots
src/cypress/runner > other specs > file with empty suites only displays no tests found		Test Replay Screenshots
src/cypress/runner > reporter interaction > user can stop test execution		Test Replay Screenshots

  cypress\e2e\studio\studio-new-tests.cy.ts • 1 failed test • app-e2e

View Output

Test		Artifacts
Cypress Studio - New Test Creation > creates a new test for a specific suite with the url already defined		Test Replay Screenshots

  cypress\e2e\choose-a-browser.cy.ts • 1 flaky test • launchpad-e2e

View Output

Test		Artifacts
Choose a browser page > System Browsers Detected > launches when --browser is passed alone through the command line		Test Replay Screenshots

  cypress\e2e\specs.cy.ts • 1 flaky test • app-e2e

View Output

Test		Artifacts
... > scaffold starter spec > should generate starter spec		Test Replay Screenshots

  cypress\e2e\cypress-origin-communicator.cy.ts • 1 flaky test • app-e2e

View Output

Test		Artifacts
Cypress In Cypress Origin Communicator > primary origin memory leak prevention > cleans up the primaryOriginCommunicator events when navigating away from the /specs to /runs		Test Replay Screenshots