Skip to content

Commit 3f1aee5

Browse files
committed
chore: remove ssh-keyscan as it shouldnt be necessary
1 parent e0b5991 commit 3f1aee5

File tree

2 files changed

+2
-15
lines changed

2 files changed

+2
-15
lines changed

.circleci/src/pipeline/@pipeline.yml

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ commands:
118118
name: Set environment variable to determine whether or not to persist artifacts
119119
command: |
120120
echo "Setting SHOULD_PERSIST_ARTIFACTS variable"
121-
echo 'if ! [[ "$CIRCLE_BRANCH" != "develop" && "$CIRCLE_BRANCH" != "release/"* && "$CIRCLE_BRANCH" != "ryanm/fix/rename-exclude-from-ai" ]]; then
121+
echo 'if ! [[ "$CIRCLE_BRANCH" != "develop" && "$CIRCLE_BRANCH" != "release/"* && "$CIRCLE_BRANCH" != "chore/fix_builds" ]]; then
122122
export SHOULD_PERSIST_ARTIFACTS=true
123123
fi' >> "$BASH_ENV"
124124
# You must run `setup_should_persist_artifacts` command and be using bash before running this command
@@ -1448,16 +1448,6 @@ commands:
14481448
- cypress/binary-url.json
14491449
- cypress/npm-package-url.json
14501450

1451-
update_known_hosts:
1452-
description: Ensures that we have the latest Git public keys to prevent git+ssh
1453-
from failing.
1454-
steps:
1455-
- run:
1456-
name: Update known_hosts with github.com keys
1457-
command: |
1458-
mkdir -p ~/.ssh
1459-
ssh-keyscan github.com >> ~/.ssh/known_hosts
1460-
14611451
jobs:
14621452
## Checks if we already have a valid cache for the node_modules_install and if it has,
14631453
## skips ahead to the build step, otherwise installs and caches the node_modules
@@ -1473,7 +1463,6 @@ jobs:
14731463
default: false
14741464
resource_class: << parameters.resource_class >>
14751465
steps:
1476-
- update_known_hosts
14771466
- checkout
14781467
- install-required-node
14791468
- verify-build-setup:
@@ -1583,7 +1572,6 @@ jobs:
15831572
echo "skipping for contributor PRs since we don't record to the cloud"
15841573
circleci-agent step halt
15851574
fi
1586-
- update_known_hosts
15871575
- run:
15881576
name: checkout
15891577
command: git clone -b "$CIRCLE_BRANCH" "$CIRCLE_REPOSITORY_URL" --depth 1
@@ -1795,7 +1783,6 @@ jobs:
17951783
GITHUB_TOKEN: $GH_TOKEN
17961784
steps:
17971785
- restore_cached_workspace
1798-
- update_known_hosts
17991786
- run: yarn test-npm-package-release-script
18001787
- run: node ./scripts/semantic-commits/validate-binary-changelog.js
18011788
- store_artifacts:

.circleci/src/pipeline/workflows/@main.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ linux-x64:
44
- equal: [ develop, << pipeline.git.branch >> ]
55
# use the following branch as well to ensure that v8 snapshot cache updates are fully tested
66
- equal: [ 'update-v8-snapshot-cache-on-develop', << pipeline.git.branch >> ]
7-
- equal: [ 'ryanm/fix/rename-exclude-from-ai', << pipeline.git.branch >> ]
7+
- equal: [ 'chore/fix_builds', << pipeline.git.branch >> ]
88
- matches:
99
pattern: /^release\/\d+\.\d+\.\d+$/
1010
value: << pipeline.git.branch >>

0 commit comments

Comments
 (0)