Improve isNumber detection #405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cucumber-react-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
mpkorstanje
force-pushed
the
improve-number-detection
branch
2 times, most recently
from
d4ad5b8 to
a4765c1
Compare
The original regex didn't match the start or end of line. Because of that any text with a number in the middle would be considered a number. Expanded it a little bit to also consider spaces and periods as thousands- and decimal-separators. Fixes: #404
mpkorstanje
force-pushed
the
improve-number-detection
branch
from
a4765c1 to
632a980
Compare
davidjgoss
approved these changes
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
The original regex didn't match the start or end of line. Because of that any text with a number in the middle would be considered a number.
Expanded it a little bit to also consider spaces and periods as thousands- and decimal-separators.
⚡️ What's your motivation?
Fixes: #404
🏷️ What kind of change is this?
📋 Checklist: