Improve isNumber detection (#405)

The original regex didn't match the start or end of line. Because of
that any text with a number in the middle would be considered a number.

Expanded it a little bit to also consider spaces and periods as
thousands- and decimal-separators.

Fixes: #404

Author: mpkorstanje

CHANGELOG.md

@@ -6,6 +6,9 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ## [Unreleased]
+### Fixed
+- Text with numbers is no longer right aligned ([#405](https://github.com/cucumber/react-components/pull/405))
+
 ### Added
 - Include duration for each test step ([#396](https://github.com/cucumber/react-components/pull/396))
 - Include pass rate in execution summary ([#397](https://github.com/cucumber/react-components/pull/397))

src/components/gherkin/isNumber.spec.ts

@@ -0,0 +1,22 @@
+import { expect } from 'chai'
+
+import isNumber from './isNumber.js'
+
+describe('isNumber is true', () => {
+  const numbers = ['1', '-1', '10', '1.0', '.0', '1,0', '1 000,00', '127.0.0.0', '10E-05', '10E+05']
+
+  numbers.forEach((value) => {
+    it(`${value}`, () => {
+      expect(isNumber(value)).to.be.true
+    })
+  })
+})
+describe('isNumber is false', () => {
+  const nonNumbers = ['hello', 'hello world', '-', '+', '1.', '1,', 'Ramayan 3392 A.D.', 'E+10']
+
+  nonNumbers.forEach((value) => {
+    it(`${value}`, () => {
+      expect(isNumber(value)).to.be.false
+    })
+  })
+})

src/components/gherkin/isNumber.ts

@@ -1,5 +1,6 @@
 // Lifted from cucumber-expressions/javascript/src/ParameterTypeRegistry#FLOAT_REGEXP
-const numberPattern = /(?=.*\d.*)[-+]?\d*(?:\.(?=\d.*))?\d*(?:\d+[E][+-]?\d+)?/
+// Modified to allow spaces, commas and periods as decimal- and/or as thousand-separators
+const numberPattern = /^(?=.*\d.*)[-+]?\d*(?:[., ](?=\d.*)\d*)*(?:\d+E[+-]?\d+)?$/
 
 export default function isNumber(s: string): boolean {
   return !!s.match(numberPattern)