-
-
Notifications
You must be signed in to change notification settings - Fork 22
Generate OSGi infos in the manifest #344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please do add a link to this PR in the changelog.
5e60ebb
to
101a87a
Compare
Just thought of something. But I don't know OSGI that well. Are these module imports? If so, then the JavaSe version shouldn't be 1.8. |
No these are packages
The project is currently compiled with Java 1.8 bytecode that's why 1.8 is used here as the minimum version. |
101a87a
to
243d853
Compare
243d853
to
f6ffe38
Compare
@mpkorstanje rebased to use the new parent, build should now succeed Final outcome is:
Manifest:
if this is merged and released I will continue with the dependent gherkin / gherkin-util. |
This pull request adds OSGi metadata support to the Java package and updates the Maven parent version. The main focus is on improving Java module compatibility with OSGi environments by updating the build configuration.
Java build and packaging improvements:
bnd-maven-plugin
topom.xml
to generate OSGi metadata, enabling better integration with OSGi-based systems.maven-jar-plugin
configuration inpom.xml
to specify the manifest file location, which is necessary for proper OSGi metadata inclusion.4.3.8
to4.3.9
inpom.xml
to ensure compatibility with the new plugins and features.Documentation:
CHANGELOG.md
to document the addition of OSGi metadata for Java.This pull request adds support for OSGi metadata to the Java build, making the project more compatible with OSGi-based environments. The main changes involve updating the Maven build configuration and documenting the addition.Build system enhancements:
bnd-maven-plugin
and configured themaven-jar-plugin
inpom.xml
to generate OSGi metadata in the build artifacts.pom.xml
to4.3.9-SNAPSHOT
to reflect the ongoing development state.Documentation:
CHANGELOG.md
under the "Added" section.This results in the following summary:
And the final manifest in the jar looks like this:
@mpkorstanje for me it all looks sane, can you review this?