Skip to content

Conversation

laeubi
Copy link
Contributor

@laeubi laeubi commented Sep 30, 2025

This adds the bnd-maven plugin to the dependency management section to allow generate OSGi metadata in an non-intrusive way.

This was discussed here:

@mpkorstanje can you review this?

This adds the bnd-maven plugin to the dependency management section to
allow generate OSGi metadata in an non-intrusive way.
@mpkorstanje mpkorstanje changed the title Add bnd-maven plugin to dependency management section Generate OSGI metadata Oct 1, 2025
@mpkorstanje mpkorstanje changed the title Generate OSGI metadata Generate OSGi metadata Oct 1, 2025
Copy link
Contributor

@mpkorstanje mpkorstanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pushed some changes. If you have no further remarks, feel free to merge. I'll trust your judgement on the directives here.

For future PRs please:

  • Feel free to create a branch in this repository. If I want to contribute to your PR it is easier if I don't first have to add your clone as a remote.

  • Add a changelog entry where relevant to the end users of this artifact (in this instance, ourselves). These changes are included on pull requests from Renovate. So this helps communicate what is in an update. For example:

Image

@laeubi
Copy link
Contributor Author

laeubi commented Oct 1, 2025

Thanks for the adjustments, I think we must try it out if it really works for all consumers but it seems a good starting point to me!

Will this deployed somewhere automatically so it can be used in the subprojects or is triggering a deployment needed?

@laeubi laeubi merged commit 227b6ae into cucumber:main Oct 1, 2025
2 checks passed
@mpkorstanje
Copy link
Contributor

mpkorstanje commented Oct 1, 2025

Will this deployed somewhere automatically so it can be used in the subprojects or is triggering a deployment needed?

A release must be made manually. If you're interested in the details:

https://github.com/cucumber/.github/blob/main/RELEASING.md

TL;DR: I'll make the release.

@mpkorstanje
Copy link
Contributor

mpkorstanje commented Oct 1, 2025

Thanks for the adjustments, I think we must try it out if it really works for all consumers but it seems a good starting point to me!

I suppose you can spot check a few versions by running mvn install on this project and using the snapshot produced in some other repositories to verify the generated information is correct. Do you want to do that first?

@laeubi
Copy link
Contributor Author

laeubi commented Oct 2, 2025

If there is a snapshot repo I can use that for (local) testing, just let me know!

@mpkorstanje
Copy link
Contributor

You can run mvn install, locally then use that version in another project. Or am I missing something?

@laeubi
Copy link
Contributor Author

laeubi commented Oct 2, 2025

You can run mvn install, locally then use that version in another project. Or am I missing something?

Okay then I misunderstood that, I now startet with a first draft PR here and will create some more so we can get a bigger picture about how this will work out:

@mpkorstanje
Copy link
Contributor

Okay. Perhaps, for tracking purposes you can create an issue in https://github.com/cucumber/common. Then you can reference that issue and not repeat yourself.

For example: cucumber/common#2281

@laeubi
Copy link
Contributor Author

laeubi commented Oct 2, 2025

I made some local test now picking some of the cucumber-jvm modules and I found no issues so far... so from my side the parent is ready to be released so we can use it in the sub projects!

@mpkorstanje
Copy link
Contributor

mpkorstanje commented Oct 2, 2025

Release in progress. Give it an hour to propagate to central.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants