-
-
Notifications
You must be signed in to change notification settings - Fork 6
Generate OSGi metadata #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This adds the bnd-maven plugin to the dependency management section to allow generate OSGi metadata in an non-intrusive way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've pushed some changes. If you have no further remarks, feel free to merge. I'll trust your judgement on the directives here.
For future PRs please:
-
Feel free to create a branch in this repository. If I want to contribute to your PR it is easier if I don't first have to add your clone as a remote.
-
Add a changelog entry where relevant to the end users of this artifact (in this instance, ourselves). These changes are included on pull requests from Renovate. So this helps communicate what is in an update. For example:

Thanks for the adjustments, I think we must try it out if it really works for all consumers but it seems a good starting point to me! Will this deployed somewhere automatically so it can be used in the subprojects or is triggering a deployment needed? |
A release must be made manually. If you're interested in the details: https://github.com/cucumber/.github/blob/main/RELEASING.md TL;DR: I'll make the release. |
I suppose you can spot check a few versions by running |
If there is a snapshot repo I can use that for (local) testing, just let me know! |
You can run |
Okay then I misunderstood that, I now startet with a first draft PR here and will create some more so we can get a bigger picture about how this will work out: |
Okay. Perhaps, for tracking purposes you can create an issue in https://github.com/cucumber/common. Then you can reference that issue and not repeat yourself. For example: cucumber/common#2281 |
I made some local test now picking some of the |
Release in progress. Give it an hour to propagate to central. |
This adds the bnd-maven plugin to the dependency management section to allow generate OSGi metadata in an non-intrusive way.
This was discussed here:
@mpkorstanje can you review this?