Skip to content

Updated Dockerfile from old syntax #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ctyano merged 2 commits into from
Dec 23, 2025
Merged

Updated Dockerfile from old syntax #22

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab35241
Updated Dockerfile from old syntax
ctyano Dec 23, 2025
378fa6a
Applied Gemini code review results
ctyano Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM docker.io/library/maven:3-eclipse-temurin-19-focal as builder
FROM docker.io/library/maven:3-eclipse-temurin-19-focal AS builder

ARG VERSION=
ARG ATHENZ_VERSION=
Expand Down Expand Up @@ -29,7 +29,7 @@
| $HOME/.local/bin/yq -p xml -o xml ".project.properties.\"java.version\"=strenv(JAVA_VERSION)" \
| tee pom.xml

ENV MAVEN_CONFIG "$HOME/.m2"
ENV MAVEN_CONFIG=$HOME/.m2

Check warning on line 32 in Dockerfile

View workflow job for this annotation

GitHub Actions / Build and Publish Docker Images / build

Variables should be defined before their use 

UndefinedVar: Usage of undefined variable '$HOME'
More info: https://docs.docker.com/go/dockerfile/rule/undefined-var/

RUN mvn -B package --file pom.xml

Expand All @@ -39,6 +39,6 @@

COPY --from=builder /target/athenz-plugins-$VERSION.jar /target/athenz-plugins-$VERSION.jar

ENV JAR_DESTINATION "/"
ENV JAR_DESTINATION=/

ENTRYPOINT ["/bin/sh", "-c", "cp -p /target/athenz-plugins-*.jar ${JAR_DESTINATION}/athenz-plugins.jar"]