Updated Dockerfile from old syntax

[ctyano]

Type of changes

Choose one of the below, or leave them empty:

• New feature proposal
• Bug fix
• Minor improvements
• Refactoring (no functional changes)
• Non-code changes (updating documentation, workflows, etc.)

[gemini-code-assist]

Summary of Changes

Hello @ctyano, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the existing Dockerfile to update its syntax to more modern conventions. The changes primarily involve minor adjustments to the FROM and ENV instructions, ensuring the Dockerfile adheres to contemporary best practices and improves readability without introducing any functional changes to the build process or the resulting image.

Highlights

• Dockerfile Syntax Update: The FROM instruction's multi-stage build alias has been updated from as to AS, aligning with modern Dockerfile syntax conventions.
• ENV Instruction Formatting: The ENV instructions for MAVEN_CONFIG and JAR_DESTINATION have been modified to remove spaces around the equals sign, standardizing the syntax.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to update the Dockerfile syntax. While the intention is good, the changes to the ENV instructions introduce critical breaking changes. The new ENV key=value syntax handles quotes differently than the older ENV key value syntax, causing the quotes to become part of the environment variable's value. This will lead to failures in subsequent commands that rely on these variables for paths. My review includes suggestions to correct this while retaining the updated syntax.

[gemini-code-assist]

This change from ENV MAVEN_CONFIG "$HOME/.m2" to ENV MAVEN_CONFIG="$HOME/.m2" introduces a breaking change. The ENV key=value syntax treats quotes as part of the value, so MAVEN_CONFIG will be set to the literal string "$HOME/.m2". This will cause the mvn command to fail because it will look for a directory with quotes in its name. The previous ENV key value syntax correctly parsed the quotes. To use the new syntax correctly, the quotes must be removed.

ENV MAVEN_CONFIG=$HOME/.m2

[gemini-code-assist]

Similar to the MAVEN_CONFIG issue, this change will cause the JAR_DESTINATION variable to be set to "/", including the quotes. This will break the ENTRYPOINT command, as cp will try to write to a path that literally contains quotes. To fix this, the quotes should be removed from the value.

ENV JAR_DESTINATION=/

[ctyano]

/gemini review

[gemini-code-assist]

Code Review

This pull request correctly updates the Dockerfile syntax, improving readability with AS and fixing latent bugs in ENV instructions by removing unnecessary quotes. The changes are a good improvement. For future enhancements, consider replacing the unconventional ENTRYPOINT (which just copies a file) with a COPY instruction during the build, optimizing build caching by using more specific COPY commands instead of COPY . ., and replacing the curl | sh pattern for better security.