Use javascript modules #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for inter-module imports and exports, with sharing of type information. Now we only need one <script /> tag in index.html and the rest of the JS gets connected with import keywords.
Collaborator
Author
|
One change I should highlight is that |
danthedaniel
force-pushed
the
js-modules
branch
from
b85609a to
da4211f
Compare
Owner
|
Yeah, looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for inter-module imports and exports, with sharing of type information. Now we only need one
<script />tag inindex.htmland the rest of the JS gets connected with import keywords.Main reason for making this change:
VSCode doesn't understand what type
translationsorfaviconCounter()are unless those files are concurrently open with the files that use those declarations. Previously you would seetranslations is not declaredwith a red squiggle.