Skip to content

Build clangd in CI and remove placeholder #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cowboydaniel merged 1 commit into from
Nov 20, 2025
Merged

Build clangd in CI and remove placeholder #315

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/android-apk.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,9 @@ jobs:

- name: Assemble debug APK
working-directory: android/android-studio
run: ./gradlew --no-daemon assembleDebug
env:
ANDROID_NDK_HOME: ${{ env.ANDROID_SDK_ROOT }}/ndk/26.1.10909125
run: ../runtime/clangd/build-clangd-android.sh && ./gradlew --no-daemon assembleDebug
Comment on lines 52 to +56
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Download LLVM sources before invoking clangd build

The new Android build step now runs ../runtime/clangd/build-clangd-android.sh before Gradle, but the workflow never fetches the LLVM sources that script requires. The script aborts immediately when $LLVM_PROJECT_DIR ($GITHUB_WORKSPACE/llvm-project by default) is absent (see android/runtime/clangd/build-clangd-android.sh lines 13‑15), so the Android APK job will fail on every run in CI after this change. Add a checkout/download of llvm-project (or set LLVM_PROJECT_DIR to an existing path) before calling the script.

Useful? React with 👍 / 👎.


- name: Upload debug APK artifact
uses: actions/upload-artifact@v4
Expand Down
Loading