Build clangd in CI and remove placeholder #315
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - name: Assemble debug APK | ||
| working-directory: android/android-studio | ||
| run: ./gradlew --no-daemon assembleDebug | ||
| env: | ||
| ANDROID_NDK_HOME: ${{ env.ANDROID_SDK_ROOT }}/ndk/26.1.10909125 | ||
| run: ../runtime/clangd/build-clangd-android.sh && ./gradlew --no-daemon assembleDebug |
There was a problem hiding this comment.
The new Android build step now runs ../runtime/clangd/build-clangd-android.sh before Gradle, but the workflow never fetches the LLVM sources that script requires. The script aborts immediately when $LLVM_PROJECT_DIR ($GITHUB_WORKSPACE/llvm-project by default) is absent (see android/runtime/clangd/build-clangd-android.sh lines 13‑15), so the Android APK job will fail on every run in CI after this change. Add a checkout/download of llvm-project (or set LLVM_PROJECT_DIR to an existing path) before calling the script.
Useful? React with 👍 / 👎.
Summary
Testing
Codex Task