feat: add paginated packet commitments query to channel/v2 #7533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damiannolan
commented
Nov 4, 2024
Comment on lines
+101
to
+104
| sequence := sdk.BigEndianToUint64([]byte(keySplit[len(keySplit)-1])) | ||
| if sequence == 0 { | ||
| return types.ErrInvalidPacket | ||
| } |
There was a problem hiding this comment.
This must be handled different to in v1 as we encode the sequence as big endian bytes when storing commitments.
If parsing the keypart as big endian uint64 fails then it will return 0 - an invalid packet sequence, and is the result of corrupted state.
|
will fix conflicts, take on review and merge while Damian's on holiday (and if any nit pops up will push) |
|
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds paginated queries for packet commitments in channel/v2.
This will be needed for relayers who will also want to query unreceived packets as packets sent must be first queried for their commitments on a source.
ref: #7478
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.