Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional grpc queries for channel/v2 #7478

Open
8 of 13 tasks
DimitrisJim opened this issue Oct 17, 2024 · 9 comments
Open
8 of 13 tasks

Add additional grpc queries for channel/v2 #7478

DimitrisJim opened this issue Oct 17, 2024 · 9 comments
Labels
feat: ibc-eureka good first issue Good for newcomers

Comments

@DimitrisJim
Copy link
Contributor

DimitrisJim commented Oct 17, 2024 •
edited
Loading

Looking at the ones existing for v1 and what we use in v2, these should probably be implemented (feel free to edit otherwise!):

All these already exist in query.proto/grpc_query.go for v1 channels. Moving them over should be relatively straight forward.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
  • Estimate provided
@DimitrisJim DimitrisJim added the good first issue Good for newcomers label Oct 17, 2024
@damiannolan damiannolan self-assigned this Oct 21, 2024
@damiannolan
Copy link
Member

I'll start by adding PacketCommitment / PacketCommitments in an isolated PR.

@damiannolan damiannolan mentioned this issue Oct 21, 2024
Merged
10 tasks
@damiannolan damiannolan moved this to In progress in IBC-GO Eureka Oct 22, 2024
This was referenced Oct 22, 2024
Merged
Merged
@damiannolan damiannolan mentioned this issue Nov 4, 2024
Merged
10 tasks
@DimitrisJim
Copy link
Contributor Author

Will add NextSequenceSend myself

@DimitrisJim DimitrisJim self-assigned this Nov 11, 2024
@DimitrisJim DimitrisJim mentioned this issue Nov 11, 2024
Merged
10 tasks
@DimitrisJim
Copy link
Contributor Author

Will pick up PacketAcknowledgements on the morrow

@DimitrisJim
Copy link
Contributor Author

need to also add Channels rpc.

@DimitrisJim DimitrisJim mentioned this issue Nov 13, 2024
Merged
10 tasks
@lacsomot lacsomot mentioned this issue Nov 14, 2024
Merged
10 tasks
@lacsomot
Copy link
Contributor

Hi. I made a PR for unreceivedPackets. #7561. Can you review it? TYSM

@DimitrisJim
Copy link
Contributor Author

thanks! Will do!

@DimitrisJim DimitrisJim mentioned this issue Nov 14, 2024
Draft
10 tasks
@DimitrisJim
Copy link
Contributor Author

Will add UnreceivedAcks

@DimitrisJim DimitrisJim mentioned this issue Nov 14, 2024
Merged
10 tasks
@DimitrisJim
Copy link
Contributor Author

hm, might also need ChannelClientState/ChannelConsensusState

@DimitrisJim DimitrisJim mentioned this issue Dec 5, 2024
Merged
10 tasks
@DimitrisJim
Copy link
Contributor Author

Unsure how grpcs will look with new proposed aliasing approach. Leaving issue as is for now.

@DimitrisJim DimitrisJim removed their assignment Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feat: ibc-eureka good first issue Good for newcomers
Projects
IBC-GO Eureka
Status: In progress
Milestone
No milestone
Development

No branches or pull requests
3 participants
@damiannolan @DimitrisJim @lacsomot