Skip to content

Replace print() statements with logger.info() in pipeline tasks (fixe…#468

Open
abhijeetnardele24-hash wants to merge 2 commits intocositools:developfrom
abhijeetnardele24-hash:develop
Open

Replace print() statements with logger.info() in pipeline tasks (fixe…#468
abhijeetnardele24-hash wants to merge 2 commits intocositools:developfrom
abhijeetnardele24-hash:develop

Conversation

@abhijeetnardele24-hash
Copy link

Summary

Replaced print() statements with proper logging using logger.info() as requested in #467.

Changes

  • Replaced 5 print() statements in cosipy/pipeline/task/task.py with logger.info() calls
  • Affected functions: cosi_bindata() and cosi_threemlfit()
  • Logging was already imported and configured in the file

Fixes #467

@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.51%. Comparing base (99bed81) to head (05069f8).

Files with missing lines Coverage Δ
cosipy/data_io/UnBinnedData.py 92.83% <ø> (-0.03%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@israelmcmc
Copy link
Collaborator

Thanks @abhijeetnardele24-hash

  • The print() statemente in cosi_threemlfit are actually OK since this function is meant to be a commandline executable and the print() output will go to stdout. Can you please revert those?
  • Did you see where the "adding XXX ..." from combined_unbinned_data are coming from? I didn't see those in your changes.
  • @GallegoSav can you please confirm that these changes are what you meant to do with issue Remind me to remove the check for old file format for DC4 #428 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Print() statement leftovers

2 participants