Skip to content

feat: Schedule CoC reminders for active students without a CoC #1468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JeangelLF merged 1 commit into from
Oct 22, 2026
+25 −0
Merged

feat: Schedule CoC reminders for active students without a CoC #1468

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions jobs/periodic/process-expired-coc/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,24 @@ import { prisma } from '../../../common/prisma';
import { getLogger } from '../../../common/logger/logger';
import moment from 'moment';
import { scheduleCoCReminders } from '../../../common/student/screening';
import { predictedHookActionDate } from '../../../common/notification';
import { userForStudent } from '../../../common/user';

const logger = getLogger();

export default async function execute() {
const thirtyThreeMonthsAgo = moment().subtract(33, 'months').toDate();
const twoMonthsAgo = moment().subtract(2, 'months').toDate();
const activeStudentsWithoutCoC = await prisma.student.findMany({
where: {
active: true,
lastLogin: {
gt: twoMonthsAgo,
},
certificate_of_conduct: { is: null },
OR: [{ screening: { status: 'success' } }, { instructor_screening: { status: 'success' } }],
},
});
const studentsWithStaleCoC = await prisma.student.findMany({
where: {
active: true,
Expand Down Expand Up @@ -37,4 +49,17 @@ export default async function execute() {
await scheduleCoCReminders(student, /** ignoreAccCreationDate: */ false, /** isRenewal: */ true);
}
logger.info(`Scheduled CoC reminders for ${studentsWithStaleCoC.length} students.`);

let scheduledForMissingCoC = 0;
for (const student of activeStudentsWithoutCoC) {
// Rescheduling cancels the pending deactivation, so students already in the countdown must be skipped
const deactivationAlreadyScheduled = await predictedHookActionDate('coc_reminder', 'deactivate-student', userForStudent(student));

@Jonasdoubleyou Jonasdoubleyou Oct 15, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I think this correctly skips our test users then?)

@JeangelLF JeangelLF Oct 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think so. One of them for example is already in the countdown and the deactivation date is set to 2050 and the other one is not screened yet

if (deactivationAlreadyScheduled) {
continue;
}
// We also treat these cases as renewals
await scheduleCoCReminders(student, /** ignoreAccCreationDate: */ false, /** isRenewal: */ true);
scheduledForMissingCoC++;
}
logger.info(`Scheduled CoC reminders for ${scheduledForMissingCoC} students without a CoC.`);
}
Loading