Repository navigation
Conversation
Jonasdoubleyou
approved these changes
Oct 15, 2026
| let scheduledForMissingCoC = 0; | ||
| for (const student of activeStudentsWithoutCoC) { | ||
| // Rescheduling cancels the pending deactivation, so students already in the countdown must be skipped | ||
| const deactivationAlreadyScheduled = await predictedHookActionDate('coc_reminder', 'deactivate-student', userForStudent(student)); |
Member
There was a problem hiding this comment.
(I think this correctly skips our test users then?)
Contributor
Author
There was a problem hiding this comment.
Yeah I think so. One of them for example is already in the countdown and the deactivation date is set to 2050 and the other one is not screened yet
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was done?
process-expired-cocjob to also include students that don't have a coc at all (and are screened), which mainly should be very old users