Repository navigation
wc3: Fit campaign mission lists and restore authored backdrop colors - #581
Merged
Merged
Conversation
Retail 1.2x captures show every RoC mission column unscrolled: Human's fourteen rows sit 0.032 apart, centred 0.285 below the top, the same pitch and centre the selector already uses. Only the slot count differed: the mission box borrowed the campaign column's ten-slot TFT scroll-bar height, so longer campaigns started scrolling. Give the mission box sixteen slots on the same centre; the campaign box keeps ten. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01SLzm4b2nJwKoBPJJHHEwqo
Static GEOA colors are already RGB. Warsmash swaps them into a BGR uniform and swaps back in its shader; copying only its first swap reversed our red and blue. Preserve static RGB while keeping animated KGAC conversion, restoring the orange Orc sky and blue Night Elf beams. Read stock-shaped Orc sky and non-stock blue GEOA records in the regression. Both failed before the fix. Full make test, renderer and RoC/TFT menu tests pass; movie-enabled framebuffer captures confirm the colors. No network or save-format changes.
corepunch
force-pushed
the
claude/campaign-mission-list-rows
branch
from
October 6, 2026 07:06
1692139 to
7cb64a2
Compare
corepunch
changed the title
corepunch
marked this pull request as ready for review
October 6, 2026 07:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Campaign mission lists longer than ten rows hid their final chapters and cinematics below the fold. The mission selector now has sixteen slots on the existing column centre and row pitch, so Human's fourteen rows and the other stock RoC campaigns fit without scrolling. Campaign selection keeps ten slots; longer custom mission lists still scroll.
The Orc campaign sky also rendered blue instead of orange because static MDX GEOA colors were incorrectly interpreted as BGR. Those fields are already RGB. Warsmash swaps its static color into a BGR uniform and then swaps back in its shader; copying only the first step reversed our red and blue. Preserve static RGB while retaining the existing animated KGAC conversion. This also restores the Night Elf campaign's blue beams and arrow.
Validation:
make testpasses, including both RoC and TFT engine runs.make test-renderer-model: 6102 assertions pass; the new parser-to-color regression failed before the correction for both the actual Orc sky record and a non-stock blue record. Existing animated-color tests continue to pass.make test-menu: 1400 assertions pass without FFmpeg; 1407 pass withFFMPEG=1, covering both archive variants.Network wire format and save format are unchanged.
Proposed review split, in commit order: (1) selector capacity, overflow fixture, and menu tests; (2) static MDX color correction, parser regression, and documentation. Both are included in this PR.