Repository navigation
WC3 ability refactor: centralize lifecycles and expand save coverage - #580
Merged
Merged
Conversation
corepunch
force-pushed
the
ability_refactor
branch
from
October 6, 2026 07:18
8bb2827 to
604c7ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch consolidates shared Warcraft III ability behavior while keeping ability-specific decisions in their owning procedures. It introduces shared helpers for spell targeting, channel and thinker identity, timed statuses, summons, corpse selection and reservation, owned effects, and relocation. Abilities retain their own targeting policy, timing, effects, and cleanup behavior.
Persistence coverage now includes live ability state, thinker callbacks, entity generations, owned effects, summons, and corpse reservations. The
unit healthandunit manacheats apply to selected controllable units, clamp values to each unit's maximum, and have regression coverage. Documentation reflects the ability architecture and verification guidance.Rebased onto main, including PR #581. Poison conflict resolution retains main's periodic damage, same-source pulse deadline, and source-incarnation checks while using the shared buff-token, duration, and timed-status helpers.
Network wire format is unchanged. WC3 save format advances from version 64 to 65; prior versions are explicitly rejected.
Validation on rebased head
604c7ff60e37236e8411cb996e6fc475858cc5b1:make testpassed, including both RoC and TFT WC3 engine runs: 46,642 assertions in 2,331 tests per run.python3 tools/wc3_ability_class_audit.py --format=coveragecompleted.python3 -m unittest tests/test_check_wc3_ability_registry.pypassed all three tests.python3 tools/engine_boundary_audit.py --base origin/mainpassed.git diff --check origin/main...HEADpassed; range-diff confirms the rebase only adapts poison handling and documentation context.Proposed review split, following existing commit dependencies: shared family helpers and ability consumers; delayed identity and persistence with regression tests; documentation and selected-group cheats. Existing commits are preserved through the rebase.