Skip to content

add if statement to check url starts with "http" then go to url directly #7874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 25, 2025
Merged

add if statement to check url starts with "http" then go to url directly #7874

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bbf12df
add if statement to check url starts with "http" then go to url directly
tommypurcell Sep 20, 2025
27f56b1
Revert core.ts to match main
tommypurcell Sep 20, 2025
3470ce6
use openUrl directly for GitHub and Discord links in StreamError.tsx
tommypurcell Sep 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions gui/src/pages/gui/StreamError.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,10 +290,7 @@ const StreamErrorDialog = ({ error }: StreamErrorProps) => {
<GhostButton
className="flex flex-row items-center gap-2 rounded px-3 py-1.5"
onClick={() => {
ideMessenger.post("controlPlane/openUrl", {
path: GITHUB_LINK,
orgSlug: undefined,
});
ideMessenger.post("openUrl", GITHUB_LINK);
}}
>
<GithubIcon className="h-5 w-5" />
Expand All @@ -302,10 +299,7 @@ const StreamErrorDialog = ({ error }: StreamErrorProps) => {
<GhostButton
className="flex flex-row items-center gap-2 rounded px-3 py-1.5"
onClick={() => {
ideMessenger.post("controlPlane/openUrl", {
path: DISCORD_LINK,
orgSlug: undefined,
});
ideMessenger.post("openUrl", DISCORD_LINK);
}}
>
<DiscordIcon className="h-5 w-5" />
Expand Down
Loading