Skip to content

Conversation

tommypurcell
Copy link
Contributor

@tommypurcell tommypurcell commented Sep 20, 2025

Description

Fixes #7873

  • Added if statement in controlPlane/openUrl to check if URL starts with http
  • Directly opens external links instead of prepending hub.continue.dev

AI Code Review

  • Team members only: AI review runs automatically when PR is opened or marked ready for review
  • Team members can also trigger a review by commenting @continue-general-review or @continue-detailed-review

Checklist

  • I've read the contributing guide
  • The relevant docs, if any, have been updated or created
  • The relevant tests, if any, have been updated or created

Screenshots

For context, see issue #7873 for broken link screenshots.

image

Summary by cubic

Open http/https URLs directly in controlPlane/openUrl instead of prefixing hub.continue.dev. Fixes broken “Report this error” links and other external links.

@tommypurcell tommypurcell requested a review from a team as a code owner September 20, 2025 07:45
@tommypurcell tommypurcell requested review from Patrick-Erichsen and removed request for a team September 20, 2025 07:45
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Sep 20, 2025
Copy link

github-actions bot commented Sep 20, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

Copy link
Collaborator

@RomneyDa RomneyDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tommypurcell instead of adding this fallback to controlPlane/openUrl, could you update the place it's called to use the expected openUrl instead?

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Sep 20, 2025
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Sep 20, 2025
@tommypurcell
Copy link
Contributor Author

tommypurcell commented Sep 20, 2025

@RomneyDa Thanks! I’ve updated the calls to use openUrl directly and reverted the changes in controlPlane/openUrl.

Copy link
Collaborator

@Patrick-Erichsen Patrick-Erichsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey nice to see you again @tommypurcell ! 👋

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 22, 2025
@Patrick-Erichsen
Copy link
Collaborator

Patrick-Erichsen commented Sep 22, 2025

This is blocked by the CLA bot, you just need to add a comment with the following:

I have read the CLA Document and I hereby sign the CLA

@tommypurcell
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@tommypurcell
Copy link
Contributor Author

Hey nice to see you again @tommypurcell ! 👋

Hey man, thought I’d pitch in a bit 😄 Cheers!

@RomneyDa RomneyDa merged commit c81b89f into continuedev:main Sep 25, 2025
54 of 56 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Sep 25, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2025
@RomneyDa
Copy link
Collaborator

@tommypurcell appreciate the fix!

@sestinj
Copy link
Contributor

sestinj commented Sep 26, 2025

🎉 This PR is included in version 1.22.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm This PR has been approved by a maintainer released size:S This PR changes 10-29 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

"Report this error" links to 404 not found
4 participants