-
Notifications
You must be signed in to change notification settings - Fork 3.5k
add if statement to check url starts with "http" then go to url directly #7874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add if statement to check url starts with "http" then go to url directly #7874
Conversation
All contributors have signed the CLA ✍️ ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tommypurcell instead of adding this fallback to controlPlane/openUrl
, could you update the place it's called to use the expected openUrl
instead?
@RomneyDa Thanks! I’ve updated the calls to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey nice to see you again @tommypurcell ! 👋
This is blocked by the CLA bot, you just need to add a comment with the following:
|
I have read the CLA Document and I hereby sign the CLA |
Hey man, thought I’d pitch in a bit 😄 Cheers! |
@tommypurcell appreciate the fix! |
🎉 This PR is included in version 1.22.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Fixes #7873
if
statement incontrolPlane/openUrl
to check if URL starts withhttp
hub.continue.dev
AI Code Review
@continue-general-review
or@continue-detailed-review
Checklist
Screenshots
For context, see issue #7873 for broken link screenshots.
Summary by cubic
Open http/https URLs directly in controlPlane/openUrl instead of prefixing hub.continue.dev. Fixes broken “Report this error” links and other external links.