Skip to content

Comments

feat!: Pass HTTP resolvers to Signer::send_timestamp_request#1852

Open
ok-nick wants to merge 19 commits intomainfrom
ok-nick/send-timestamp-request-respect
Open

feat!: Pass HTTP resolvers to Signer::send_timestamp_request#1852
ok-nick wants to merge 19 commits intomainfrom
ok-nick/send-timestamp-request-respect

Conversation

@ok-nick
Copy link
Contributor

@ok-nick ok-nick commented Feb 12, 2026

This PR builds off the changes in #1846 to pass HTTP resolvers to the Signer::send_timestamp_request function. Our current code creates a new HTTP resolver on the fly for timestamping and doesn't respect the one contained in the resolver, this PR fixes that. It is step one to solving #1816, where we change the timestamp assertion code to call the signer function.

Note, some of the changes in #1846 are done here as well, so let's get that PR through first.

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 12, 2026

Merging this PR will not alter performance

✅ 16 untouched benchmarks
⏩ 2 skipped benchmarks1


Comparing ok-nick/send-timestamp-request-respect (9e38bda) with main (d3488ec)2

Open in CodSpeed

Footnotes

  1. 2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (a2ec0ea) during the generation of this report, so d3488ec was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@ok-nick ok-nick changed the title feat: Pass HTTP resolvers to Signer::send_timestamp_request feat!: Pass HTTP resolvers to Signer::send_timestamp_request Feb 12, 2026
Copy link
Collaborator

@gpeacock gpeacock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question about if you meant to keep commented out code.

@ok-nick ok-nick changed the base branch from main to ok-nick/sign-async-send February 12, 2026 22:08
@ok-nick ok-nick changed the base branch from ok-nick/sign-async-send to main February 12, 2026 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Singer/AsyncSigner send_timestamp_request() method is not called for timestamping.

2 participants