feat!: Pass HTTP resolvers to Signer::send_timestamp_request#1852
Open
feat!: Pass HTTP resolvers to Signer::send_timestamp_request#1852
Signer::send_timestamp_request#1852Conversation
…P resolver traits
Merging this PR will not alter performance
Comparing Footnotes
|
ok-nick
commented
Feb 12, 2026
Signer::send_timestamp_requestSigner::send_timestamp_request
gpeacock
approved these changes
Feb 12, 2026
Collaborator
gpeacock
left a comment
There was a problem hiding this comment.
Just a question about if you meant to keep commented out code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR builds off the changes in #1846 to pass HTTP resolvers to the
Signer::send_timestamp_requestfunction. Our current code creates a new HTTP resolver on the fly for timestamping and doesn't respect the one contained in the resolver, this PR fixes that. It is step one to solving #1816, where we change the timestamp assertion code to call the signer function.Note, some of the changes in #1846 are done here as well, so let's get that PR through first.