Skip to content

Comments

feat!: call Signer::send_timestamp_request for timestamp assertions#1855

Open
ok-nick wants to merge 18 commits intomainfrom
ok-nick/tsa-assertion-call-signer
Open

feat!: call Signer::send_timestamp_request for timestamp assertions#1855
ok-nick wants to merge 18 commits intomainfrom
ok-nick/tsa-assertion-call-signer

Conversation

@ok-nick
Copy link
Contributor

@ok-nick ok-nick commented Feb 12, 2026

Builds off the work in #1846 and #1852 to call Signer::send_timestamp_request for timestamp assertions using the HTTP resolver supplied in the context.

Note #1846 and #1852 should be merged before merging this PR.

@ok-nick ok-nick changed the base branch from main to ok-nick/send-timestamp-request-respect February 12, 2026 22:08
@ok-nick ok-nick changed the base branch from ok-nick/send-timestamp-request-respect to main February 12, 2026 22:09
@codspeed-hq
Copy link

codspeed-hq bot commented Feb 12, 2026

Merging this PR will not alter performance

✅ 16 untouched benchmarks
⏩ 2 skipped benchmarks1


Comparing ok-nick/tsa-assertion-call-signer (58e3aca) with main (81033e0)

Open in CodSpeed

Footnotes

  1. 2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Singer/AsyncSigner send_timestamp_request() method is not called for timestamping.

1 participant