HMS-9590: update repos and scripts upon frontend refactor#1358
HMS-9590: update repos and scripts upon frontend refactor#1358Starle21 wants to merge 1 commit intocontent-services:mainfrom
Conversation
There was a problem hiding this comment.
1 comment for the new command, I think we should update the old one instead 💭
and this PR is also missing an update to the GH workflow for CI where the command is used (we also run frontend tests there, so those would break after the FE changes) 👀
one other thing is, if the small codeready repo would be removed from the setup, some of our backend PW tests would break
(also in the helpers inside test-utils, we have a constant with the URL for the small testing repo, that might also need to be changed, if the repo isn't going to be available) 😅
mk/repos.mk
Outdated
| .PHONY: repos-initial | ||
| repos-initial: ## Import and snapshot or introspect repos needed before running Playwright tests, the repos used: HARDCODED + EPEL10 | ||
| OPTIONS_REPOSITORY_IMPORT_FILTER=hardcoded go run ./cmd/external-repos/main.go import | ||
| go run cmd/external-repos/main.go snapshot --url https://cdn.redhat.com/content/dist/rhel10/10/aarch64/appstream/os/ --force | ||
| OPTIONS_REPOSITORY_IMPORT_FILTER=hardcoded go run ./cmd/external-repos/main.go import | ||
| go run cmd/external-repos/main.go snapshot --url https://cdn.redhat.com/content/dist/rhel10/10/aarch64/baseos/os/ --force | ||
| OPTIONS_REPOSITORY_IMPORT_FILTER=epel10 go run ./cmd/external-repos/main.go import | ||
| go run cmd/external-repos/main.go introspect --url https://dl.fedoraproject.org/pub/epel/10/Everything/x86_64/ --force |
There was a problem hiding this comment.
I don't think it makes sense to have a new command for this 🤔
The purpose of repos-minimal was to import the minimal collection of repos needed for local testing (FE+BE), namely the Playwright tests, if the requirements for that changed, so should the command. Without it being used for the setup in PR checks or locally, it would sort of loose its purpose 😅
There was a problem hiding this comment.
Thank you for your inputs! I was not clear about whether the command is also meant to be used somewhere else. If not then I agree that there is no reason to create a new command.
I will therefore update the old one to use the new repositories.
Regarding the small codeready repo - if some backend PW tests were to fail, then I think it is no problem to add it there, since it is small, it won't really extend the import time.
So I will add that repo back into the command.
Due to the frontend refactor in frontend PR content-services#763, there was a need to update playwright tests, the accompanied repositories and the script that are used for local playwright tests. The script repos-minimal imports the previous EPEL and SMALL repo, plus 2 hardcoded repos. A new script which counts the duration how long it takes to import and snapshot or introspect the required repos for testing has been added.
| repos-minimal: ## Import and snapshot or introspect repos needed before running Playwright tests, the repos used: HARDCODED (2) + SMALL + EPEL10 | ||
| OPTIONS_REPOSITORY_IMPORT_FILTER=hardcoded go run ./cmd/external-repos/main.go import | ||
| go run cmd/external-repos/main.go snapshot --url https://cdn.redhat.com/content/dist/rhel10/10/aarch64/appstream/os/ --force | ||
| OPTIONS_REPOSITORY_IMPORT_FILTER=hardcoded go run ./cmd/external-repos/main.go import |
There was a problem hiding this comment.
is there a reason for the second import? 🤔 it should be enough to only import it once 😅
3 participants
Due to the frontend refactor in frontend PR #763,
there was a need to update playwright tests
and the accompanied repositories and the script
that are used for local playwright tests.
Now,
repos-minimalscript importshardcodedrepositoriesnext to the original
epel10andsmallrepositories.A new script which counts
the duration how long it takes to import
and snapshot or introspect the required repos
for testing has been added.