HMS-9590: refactor create template feature#763
Draft
Starle21 wants to merge 34 commits intocontent-services:mainfrom
Draft
HMS-9590: refactor create template feature#763Starle21 wants to merge 34 commits intocontent-services:mainfrom
Starle21 wants to merge 34 commits intocontent-services:mainfrom
Conversation
Contributor
Starle21
changed the title
Starle21
force-pushed
the
HMS-9590
branch
15 times, most recently
from
fd23679 to
38391bc
Compare
Starle21
force-pushed
the
HMS-9590
branch
9 times, most recently
from
c1b55d7 to
75a9b69
Compare
remove unecessary validation check of editUUID remove comments
Starle21
force-pushed
the
HMS-9590
branch
2 times, most recently
from
fd04c64 to
cd663c7
Compare
remove unnecessary set data structures in AddTemplateContext, replace with simple array, remove templateRequest object, replace with atomic useStates for template's constituent part, make necessary changes in downstream stores and components, make components in each step depend on their respective step stores
to better capture its purpose
…content always expanded
…ed; divide table into subcomponents, divide table controls into subcomponents
…urns in top component and controls
Changes in the code of the create template feature prompted changing the playwright tests. The biggest change involves importing and snapshotting hardcoded repositories, that a template cannot be created without. The previous version of the playwright tests was not properly testing this requirement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Please open and see detailed notes for the refactor in
src/features/notes-refactor.Testing steps
Manual testing
To be able to compare and run both the old and the new code,
I created a temporary path, which I placed the original code under, at
insights/content/templates/originalThe new code is under the original path
insights/content/templates/addPlaywright tests
Please note that the playwright integration test
InstallUploadRepoContent.specis failingdue to an unknown reason and the issue is being investigatied. However, this does not
block you from reviewing and manually testing this PR.
For testing with playwright locally, you need to run this PR with this backend PR below:
#testwith content-services/content-sources-backend#1358