integration: add test for OCI <-> docker-archive translation #280

cyphar · 2016-12-28T07:15:08Z

There have been a long string of bugs discovered while testing this
functionality, and it's quite important the we ensure that this doesn't
break.

Signed-off-by: Aleksa Sarai [email protected]

There have been a long string of bugs discovered while testing this functionality, and it's quite important the we ensure that this doesn't break. Signed-off-by: Aleksa Sarai <[email protected]>

cyphar · 2016-12-28T07:15:38Z

DO NOT MERGE. This depends on containers/image#193 ~~(thus also #279)~~ and containers/image#143.

mtrmac

(Very nitpicky comments, feel free to ignore; and most importantly, containers/image#192 needs to be decided first.)

mtrmac · 2017-01-07T04:52:23Z

integration/copy_test.go

+
+	// docker-archive -> OCI image layout
+	ociDest := "busybox-latest"
+	defer os.RemoveAll(ociDest)


Why is this one not a TempDir as above? (Perhaps check how TestCopyDirSignature does this, with so many directories.)

Yes, it should be a TempDir.

mtrmac · 2017-01-07T04:55:22Z

integration/copy_test.go

 	c.Assert(err, check.IsNil)
 }

+// Make sure that docker-archive is identical to docker.


This is not really describing the test… what would “a local file being identical to a remote repository” (or is it “to a daemon”) mean? And docker does nothing with OCI…

I guess, a test is a test is a test, and it is useful even if not explained, but knowing what is being tested could make it easier in the future to figure out whether a failure is a bug in the test or in the software being tested.

mtrmac · 2017-01-07T04:56:29Z

integration/copy_test.go

+	// "pull": docker: → docker-archive:
+	assertSkopeoSucceeds(c, "", "copy", "docker://busybox", "docker-archive:"+ar1+"/archive.tar:busybox")
+	// "copy": docker-archive: → dir:
+	assertSkopeoSucceeds(c, "", "copy", "docker-archive:"+ar1+"/archive.tar", "dir:"+dir1)


Is it essential that this uncompressess the layers (per #279 and containers/image#193 ), or does it not matter here?

This does matter for the test below. However, since the original idea behind containers/image#193 was NACK'd, the current system will have the blobs decompressed in the docker-archive: case but I don't think it'll happen in the docker:// case.

But first lets get the other stuff merged and we can figure out how to make a nice integration test once the code works.

mtrmac · 2017-01-07T04:59:16Z

integration/copy_test.go

+	assertSkopeoSucceeds(c, "", "copy", "docker-archive:"+ar1+"/archive.tar", "dir:"+dir1)
+	// "pull": docker: → dir:
+	assertSkopeoSucceeds(c, "", "copy", "docker://busybox", "dir:"+dir2)
+	out := combinedOutputOfCommand(c, "diff", "-urN", dir1, dir2)


Sure, layers should match (either uncompressed or unmodified); but why should we expect the manifest, which has been thrown away in the copy to docker-archive:ar1, and generated from scratch in the copy from it, to match (and keep matching) byte-for-byte the manifest stored in the remote docker://busybox repo?

I'll split this test to look like #306, where we have a test that checks something that must be invariant but also an extra test that checks the things-that-should-be-the-same, with a comment explaining the situation.

mtrmac · 2017-01-07T05:02:11Z

integration/copy_test.go

+
+	// OCI image layout -> docker-archive
+	assertSkopeoSucceeds(c, "", "copy", "oci:"+ociDest, "docker-archive:"+ar2+"/archive.tar")
+	c.Assert(err, check.IsNil)


Are these two copies intended to be just a minimal smoke test, or is there a more specific kind of failure this is testing for?

There were a variety of failures that would happen if you tried to test going from OCI to Docker, back to OCI then back to Docker. This is a smoke test to ensure that at the very least we don't have asymmetric issues with one side of the conversion.

For example, the most recent series of issues we've seen would've been caught by this smoke test.

However, I will add some extra round-trip style tests (like #306) once the two important PRs are merged. I'm not going to waste time writing lots of detailed tests until we all agree on the implementations (especially semantics like compression, which massively change what invariants we can test).

cyphar · 2017-02-15T12:23:58Z

#305 wouldn't have happened if we had these tests in place... sigh

cyphar · 2017-02-15T14:20:25Z

I'm going to make a separate PR for doing regular OCI <-> Docker tests. Because really need these tests in place.

mtrmac · 2017-02-15T17:48:10Z

#305 wouldn't have happened if we had these tests in place... sigh

FWIW, note that containers/image#148 is still pending.

cyphar · 2017-02-15T17:49:42Z

Yeah, which is why I've split out #306 so we get /some/ tests in place.

rhatdan · 2017-08-14T12:04:55Z

Is this pull request still being worked on ?

cyphar · 2017-08-14T15:27:59Z

I haven't touched this in a while, but we still should include these tests. Also, there are some other issues that I've found in skopeo (such as the tags being lost bug) that we need to make sure don't get regressed on.

I'll rebase and rework this patch when I get a chance this week.

rhatdan · 2018-03-08T22:07:48Z

@cyphar This needs an update or it needs to be closed.

cyphar · 2018-03-13T05:28:30Z

/me will rebase (and probably rewrite) this.

rhatdan · 2018-09-21T12:11:01Z

@cyphar Nothing has happened to this PR in 6 months, should I close?

rhatdan · 2019-04-25T10:28:01Z

@cyphar I am closing this since nothing has happened in over a year. Reopen if you are still interested in workin on it.

integration: add test for OCI <-> docker-archive translation

493636a

There have been a long string of bugs discovered while testing this functionality, and it's quite important the we ensure that this doesn't break. Signed-off-by: Aleksa Sarai <[email protected]>

mtrmac reviewed Jan 7, 2017

View reviewed changes

cyphar mentioned this pull request Feb 15, 2017

docker-daemon: transparently decompress layers in GetBlob containers/image#193

Merged

cyphar mentioned this pull request Aug 14, 2017

[donotmerge] integration: use ::compress option for compression tests #279

Closed

rhatdan closed this Apr 25, 2019

github-actions bot added the locked - please file new issue/PR label Oct 3, 2023

github-actions bot locked as resolved and limited conversation to collaborators Oct 3, 2023

integration: add test for OCI <-> docker-archive translation #280

integration: add test for OCI <-> docker-archive translation #280

Uh oh!

Conversation

cyphar commented Dec 28, 2016

Uh oh!

cyphar commented Dec 28, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mtrmac left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cyphar commented Feb 15, 2017

Uh oh!

cyphar commented Feb 15, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mtrmac commented Feb 15, 2017

Uh oh!

cyphar commented Feb 15, 2017

Uh oh!

rhatdan commented Aug 14, 2017

Uh oh!

cyphar commented Aug 14, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rhatdan commented Mar 8, 2018

Uh oh!

cyphar commented Mar 13, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rhatdan commented Sep 21, 2018

Uh oh!

rhatdan commented Apr 25, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cyphar commented Dec 28, 2016 •

edited

Loading

cyphar commented Feb 15, 2017 •

edited

Loading

cyphar commented Aug 14, 2017 •

edited

Loading

cyphar commented Mar 13, 2018 •

edited

Loading