[donotmerge] integration: use ::compress option for compression tests #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to pending changes in containers/image, it is necessary that we explicitly make compression enabled in the tests which require it. The old behaviour was based on broken semantics (that compression would never be un-done if you're changing compression policies). Signed-off-by: Aleksa Sarai <[email protected]>
Contributor
Author
|
DO NOT MERGE. This depends on containers/image#193. |
mtrmac
reviewed
Jan 7, 2017
|
|
||
| assertSkopeoSucceeds(c, "", "--tls-verify=false", "copy", "dir:fixtures/"+t.fixture, t.remote) | ||
| assertSkopeoSucceeds(c, "", "--tls-verify=false", "copy", t.remote, "dir:"+dir) | ||
| assertSkopeoSucceeds(c, "", "--tls-verify=false", "copy", t.remote, "dir:"+dir+"::compress") |
Contributor
There was a problem hiding this comment.
See the discussion in containers/image#192 and containers/image#193 — this significantly weakens the test, now we don't really know whether the compression has happened on push or pull.
Member
|
Is this pull request still something we are considering? |
Contributor
Author
|
I think we decided it wasn't a good idea, but that means I'll have to rethink #280. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to pending changes in containers/image, it is necessary that we
explicitly make compression enabled in the tests which require it. The
old behaviour was based on broken semantics (that compression would
never be un-done if you're changing compression policies).
Signed-off-by: Aleksa Sarai [email protected]