-
-
Notifications
You must be signed in to change notification settings - Fork 89
Fix patches for cuda 12.9 #468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/19908328920. Examine the logs at this URL for more detail. |
4addc05 to
4e8d062
Compare
recipe/patches/0044-Support-for-TFv2.20-to-compile-with-CUDA-v12.9.1.patch
Show resolved
Hide resolved
|
We might want to look into fixing the zstd issues if it is easy. I’m no bazel expert though |
Bazel is never easy (that's paraphrasing @xhochy, who's much more knowledgeable about this than me). I suggest not to couple the two PRs. |
|
unfortunately, this still doesn't pass our internal tests. Other potential patches: Perhaps we can pull the builds and just try to build 1.20 instead of patching 1.19? |
| From: aravindhbalaji1985 <[email protected]> | ||
| Date: Mon, 25 Aug 2025 15:15:14 -0700 | ||
| Subject: [PATCH 44/44] Support for TFv2.20 to compile with CUDA v12.9.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest, if I were to have done this, this would have appeared as my name.
I could have added aravind's name in the commit message.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
git commit --amend --author="aravindhbalaji1985 <[email protected]>" --date="Mon, 25 Aug 2025 15:15:14 -0700"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks this helps and I’ll keep this in my backpocket for future patching!
…5.12.01.11.54.38 Other tools: - conda-build 25.11.0 - rattler-build 0.53.0 - rattler-build-conda-compat 1.4.9
466e753 to
96347a9
Compare
…5.12.01.11.54.38 Other tools: - conda-build 25.11.0 - rattler-build 0.53.0 - rattler-build-conda-compat 1.4.9
Trying to address #467 (comment)
but will have to verify that this is working by uploading to my channel.
We have an internal test that seems to be failing with the latest 12.9 build.
Checklist
0(if the version changed)conda-smithy(Use the phrase@conda-forge-admin, please rerenderin a comment in this PR for automated rerendering)