Skip to content

Conversation

@hmaarrfk
Copy link
Contributor

@hmaarrfk hmaarrfk commented Dec 1, 2025

Trying to address #467 (comment)

but will have to verify that this is working by uploading to my channel.

We have an internal test that seems to be failing with the latest 12.9 build.
Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Dec 1, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.
  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/19908328920. Examine the logs at this URL for more detail.

@hmaarrfk hmaarrfk force-pushed the fix_patches_for_12.9 branch from 4addc05 to 4e8d062 Compare December 1, 2025 03:20
@hmaarrfk hmaarrfk mentioned this pull request Dec 1, 2025
5 tasks
@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Dec 1, 2025

We might want to look into fixing the zstd issues if it is easy.

I’m no bazel expert though

@h-vetinari
Copy link
Member

We might want to look into fixing the zstd issues if it is easy.

Bazel is never easy (that's paraphrasing @xhochy, who's much more knowledgeable about this than me). I suggest not to couple the two PRs.

@hmaarrfk
Copy link
Contributor Author

hmaarrfk commented Dec 1, 2025

unfortunately, this still doesn't pass our internal tests.

Other potential patches:
tensorflow/tensorflow#90494

Perhaps we can pull the builds and just try to build 1.20 instead of patching 1.19?

Comment on lines 2 to 4
From: aravindhbalaji1985 <[email protected]>
Date: Mon, 25 Aug 2025 15:15:14 -0700
Subject: [PATCH 44/44] Support for TFv2.20 to compile with CUDA v12.9.1
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, if I were to have done this, this would have appeared as my name.

I could have added aravind's name in the commit message.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git commit --amend --author="aravindhbalaji1985 <[email protected]>" --date="Mon, 25 Aug 2025 15:15:14 -0700"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this helps and I’ll keep this in my backpocket for future patching!

…5.12.01.11.54.38

Other tools:
- conda-build 25.11.0
- rattler-build 0.53.0
- rattler-build-conda-compat 1.4.9
@hmaarrfk hmaarrfk force-pushed the fix_patches_for_12.9 branch from 466e753 to 96347a9 Compare December 1, 2025 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants