Skip to content

CUDA 12.9 support #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hmaarrfk merged 4 commits into from
Nov 28, 2025
Merged

CUDA 12.9 support #467

hmaarrfk merged 4 commits into from
Nov 28, 2025

Conversation

@isuruf
Copy link
Member

@isuruf isuruf commented Nov 21, 2025

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@isuruf
Add cuda 12.9 migration
ef1f736
@isuruf
MNT: Re-rendered with conda-smithy 3.53.2 and conda-forge-pinning 202…
ec952b5 
…5.11.21.16.58.07

    Other tools:
    - conda-build 25.9.0
    - rattler-build 0.47.0
    - rattler-build-conda-compat 1.4.5
@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Nov 21, 2025 •
edited
Loading

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.
  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/19729656547. Examine the logs at this URL for more detail.

@isuruf
Copy link
Member Author

isuruf commented Nov 28, 2025

This is ready

@hmaarrfk
Copy link
Contributor

hmaarrfk commented Nov 28, 2025

failures do not seem related. merging.

@hmaarrfk hmaarrfk merged commit 393c877 into conda-forge:main Nov 28, 2025
7 of 11 checks passed
@h-vetinari h-vetinari mentioned this pull request Nov 29, 2025
Closed
hmaarrfk
hmaarrfk reviewed Dec 1, 2025
View reviewed changes
recipe/patches/0044-Support-for-TFv2.20-to-compile-with-CUDA-v12.9.1.patch

// verbose declaration needed due to template
- GPU_DYNAMIC_SHARED_MEM_DECL(sizeof(T), unsigned char, smem);
+ GPU_DYNAMIC_SHARED_MEM_DECL(2, unsigned char, smem);
Copy link
Contributor

@hmaarrfk hmaarrfk Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this actually correct? this build of tensorflow is giving errors on my GPUs.

Copy link
Contributor

@hmaarrfk hmaarrfk Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed, they seem to align at 16
tensorflow/tensorflow@6014ea0

Copy link
Member

@h-vetinari h-vetinari Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like we need to backport that commit...

Copy link
Contributor

@hmaarrfk hmaarrfk Dec 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying it out in #468

@hmaarrfk hmaarrfk mentioned this pull request Dec 1, 2025
Draft
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hmaarrfk hmaarrfk hmaarrfk left review comments

@FarhanTejani FarhanTejani Awaiting requested review from FarhanTejani FarhanTejani is a code owner

@ghego ghego Awaiting requested review from ghego ghego is a code owner

@h-vetinari h-vetinari Awaiting requested review from h-vetinari h-vetinari is a code owner

@hajapy hajapy Awaiting requested review from hajapy hajapy is a code owner

@jschueller jschueller Awaiting requested review from jschueller jschueller is a code owner

@ngam ngam Awaiting requested review from ngam ngam is a code owner

@njzjz njzjz Awaiting requested review from njzjz njzjz is a code owner

@waitingkuo waitingkuo Awaiting requested review from waitingkuo waitingkuo is a code owner

@wolfv wolfv Awaiting requested review from wolfv wolfv is a code owner

@xhochy xhochy Awaiting requested review from xhochy xhochy is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@isuruf @conda-forge-admin @hmaarrfk @h-vetinari