-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding imdclient package of IMDv3 #28554
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/imdclient/meta.yaml:
For recipes/imdclient/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12304684940. Examine the logs at this URL for more detail. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/imdclient/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12361568956. Examine the logs at this URL for more detail. |
@hcho38 can you please add me to the maintainer list? Thanks. I am willing to be a maintainer. |
I am willing to be a maintainer |
recipe-maintainers: | ||
- hcho38 | ||
- ljwoods2 | ||
- amruthesht |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am willing to be a maintainer (and the package is hosted in my groups GitHub so I have to ensure that at least one person has long-term access).
- amruthesht | |
- amruthesht | |
- orbeckst |
I am willing to be a maintainer |
@conda-forge-admin, please ping conda-forge/help-python, ready for review |
Hi! This is the friendly automated conda-forge-webservice. I was asked to ping @conda-forge/help-python, and so here I am doing that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, but could you have a look at our docs on noarch: python
:
https://conda-forge.org/docs/maintainer/knowledge_base/#noarch-python
We are now enforcing a python_min
, so you'll want to follow the convention we have there.
@synapticarbors I made the changes to the recipe based on your comment and the documentation |
Co-authored-by: Joshua Adelman <[email protected]>
Co-authored-by: Joshua Adelman <[email protected]>
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Thank you, @synapticarbors ! |
@orbeckst you're welcome! It's always fun to see biophysics folks from my previous life pop up on here. |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).