Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding imdclient package of IMDv3 #28554

Merged
merged 10 commits into from
Dec 16, 2024
Merged

Conversation

hcho38
Copy link
Contributor

@hcho38 hcho38 commented Dec 12, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/imdclient/meta.yaml) and found some lint.

Here's what I've got...

For recipes/imdclient/meta.yaml:

  • ❌ The about section contained an unexpected subsection name. docurl is not a valid subsection name.
  • ❌ The about section contained an unexpected subsection name. devurl is not a valid subsection name.

For recipes/imdclient/meta.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the host section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • For the run section of the recipe, you should usually use python >={{ python_min }} for the python entry.
    • For the test.requires section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12304684940. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Dec 12, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/imdclient/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/imdclient/meta.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the run section of the recipe, you should usually use python >={{ python_min }} for the python entry.
    • For the test.requires section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12361568956. Examine the logs at this URL for more detail.

@orbeckst
Copy link

@hcho38 can you please add me to the maintainer list? Thanks.

I am willing to be a maintainer.

@ljwoods2
Copy link
Contributor

I am willing to be a maintainer

recipe-maintainers:
- hcho38
- ljwoods2
- amruthesht

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am willing to be a maintainer (and the package is hosted in my groups GitHub so I have to ensure that at least one person has long-term access).

Suggested change
- amruthesht
- amruthesht
- orbeckst

@amruthesht
Copy link

I am willing to be a maintainer

@hcho38
Copy link
Contributor Author

hcho38 commented Dec 13, 2024

@conda-forge-admin, please ping conda-forge/help-python, ready for review

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/help-python, and so here I am doing that.

Copy link
Member

@synapticarbors synapticarbors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, but could you have a look at our docs on noarch: python:
https://conda-forge.org/docs/maintainer/knowledge_base/#noarch-python

We are now enforcing a python_min, so you'll want to follow the convention we have there.

@hcho38
Copy link
Contributor Author

hcho38 commented Dec 16, 2024

@synapticarbors I made the changes to the recipe based on your comment and the documentation

hcho38 and others added 2 commits December 16, 2024 14:47
@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/imdclient/meta.yaml) and found it was in an excellent condition.

@synapticarbors synapticarbors merged commit 95fe9ea into conda-forge:main Dec 16, 2024
7 checks passed
@orbeckst
Copy link

Thank you, @synapticarbors !

@synapticarbors
Copy link
Member

@orbeckst you're welcome! It's always fun to see biophysics folks from my previous life pop up on here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

6 participants