Rebuild for CFEP-25 noarch: python syntax
#4
Conversation
…onda-forge-pinning 2024.12.15.16.05.58
regro-cf-autotick-bot
requested review from
IAlibay,
lilyminium and
orbeckst
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
| @@ -27,22 +27,22 @@ outputs: | |||
| noarch: python | |||
| requirements: | |||
| host: | |||
| - python >=3.9 | |||
| - python {{ python_min }} | |||
There was a problem hiding this comment.
| - python {{ python_min }} | |
| - python >=3.10 |
There was a problem hiding this comment.
Yeah, reading through CFEP-25 I'm not sure I understand the logic of requiring the minimum version on the host? 🤔
There was a problem hiding this comment.
AFAICT the discussion is on updating the python_min pin, but the bot PR here and elsewhere removes the >= in favour of just requiring the minimum version -- I don't understand this (unless I've misunderstood the syntax).
There was a problem hiding this comment.
See my comment in the main PR thread: for another PR, this was set to >= so the bot is doing something odd.
There was a problem hiding this comment.
Oops... ^h^h ... the change that I referred to was in run and not in host: there it is also pinned to python {{ python_min }}.
| - setuptools >=40.9.0 | ||
| - wheel | ||
| - pip | ||
| run: | ||
| - python >=3.9 | ||
| - python >={{ python_min }} |
There was a problem hiding this comment.
| - python >={{ python_min }} | |
| - python >=3.10 |
|
The docs https://conda-forge.org/docs/maintainer/knowledge_base/#noarch-python say
and then they recommend (EDIT: not "recommend" but "if you need to override") to set |
|
I think https://github.com/conda-forge/cfep/blob/main/cfep-25.md is what recently changed and they want to use |
Ah yes, I saw scipy do this before! we can set it in the meta.yaml, completely went over my head. |
|
We had some help on conda-forge/staged-recipes#28554 and there we have now requirements:
host:
- python {{ python_min }|
...
run:
- python >={{ python_min }}
...
test:
...
requires:
- python {{ python_min }} |
| @@ -27,22 +27,22 @@ outputs: | |||
| noarch: python | |||
| requirements: | |||
| host: | |||
| - python >=3.9 | |||
| - python {{ python_min }} | |||
There was a problem hiding this comment.
Oops... ^h^h ... the change that I referred to was in run and not in host: there it is also pinned to python {{ python_min }}.
The latest release of mdahole2 supports 3.10 as minimal python.
There was a problem hiding this comment.
Overriding python_min in meta.yml seems to work.
As this is the recommended approach for overriding and because the package requires minimal 3.10, I am approving.
|
@lilyminium @IAlibay are you happy with setting |
regro-cf-autotick-bot
deleted the
noarch_python_min-migration-1_he75a9a
branch
This PR updates the recipe to use the
noarch: pythonsyntax as described in CFEP-25. Please see our documentation for more details.If this PR was opened in error or needs to be updated please add the
bot-rerunlabel to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun botin a PR comment to have theconda-forge-adminadd it for you.This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/12342125756 - please use this URL for debugging.