openmp v21.1.2#189
Conversation
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/18110502806. Examine the logs at this URL for more detail. |
| # avoid building up system linker on macos which demands a deployment target >=14.0 | ||
| - export LD=$PREFIX/bin/ld # [osx] |
There was a problem hiding this comment.
@isuruf, please let me know what you think about this. It seems even an invocation of $PREFIX/bin/clang will now fall back go /usr/bin/ld, which then fails.
31e056a to
18b9f0e
Compare
|
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was not passing and not merged. |
|
Hi! This is the friendly conda-forge automerge bot! Commits were made to this PR after the |
|
Hi! This is the friendly automated conda-forge-linting service. I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/18133229484. Examine the logs at this URL for more detail. |
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/18136091716. Examine the logs at this URL for more detail. |
|
Hi! This is the friendly conda-forge automerge bot! Commits were made to this PR after the |
h-vetinari
left a comment
There was a problem hiding this comment.
Thank you very much for fixing this! Just one question
| - test -f $PREFIX/include/omp.h # [unix] | ||
| - if not exist %LIBRARY_INC%\omp.h exit 1 # [win] | ||
| # clang-specific one (symlink on unix; copies on win, see install_pkg.bat) | ||
| - test -f $PREFIX/lib/clang/{{ clang_major }}/include/omp.h # [unix] |
There was a problem hiding this comment.
Why did you delete this test? It ensures that the header is where clang expects it?
There was a problem hiding this comment.
We don't have clang-{{ clang_major }} in the test environment.
| - clangxx <={{ version }} | ||
| - clang-{{ clang_test_version }} | ||
| - {{ compiler('cxx') }} | ||
| - ld64 # [osx] |
There was a problem hiding this comment.
We can probably delete this one again.
It is very likely that the current package version for this feedstock is out of date.
Checklist before merging this PR:
license_fileis packagedInformation about this PR:
@conda-forge-admin,please add bot automergein the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.bot-rerunlabel to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun botin a PR comment to have theconda-forge-adminadd it for you.Closes: #188
Pending Dependency Version Updates
Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.
This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/17961844344 - please use this URL for debugging.