Skip to content

openmp v21.1.2#189

Merged
isuruf merged 12 commits into
conda-forge:mainfrom
regro-cf-autotick-bot:21.1.2_hb35c82
Sep 30, 2025
Merged

openmp v21.1.2#189
isuruf merged 12 commits into
conda-forge:mainfrom
regro-cf-autotick-bot:21.1.2_hb35c82

Conversation

@regro-cf-autotick-bot
Copy link
Copy Markdown
Contributor

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Closes: #188

Pending Dependency Version Updates

Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.

Name Upstream Version Current Version
clangdev 21.1.2 Anaconda-Server Badge

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/17961844344 - please use this URL for debugging.

@conda-forge-admin
Copy link
Copy Markdown
Contributor

conda-forge-admin commented Sep 24, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/18110502806. Examine the logs at this URL for more detail.

Comment thread recipe/meta.yaml Outdated
Comment on lines +104 to +105
# avoid building up system linker on macos which demands a deployment target >=14.0
- export LD=$PREFIX/bin/ld # [osx]
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isuruf, please let me know what you think about this. It seems even an invocation of $PREFIX/bin/clang will now fall back go /usr/bin/ld, which then fails.

@isuruf isuruf added the automerge Merge the PR when CI passes label Sep 29, 2025
@conda-forge-admin
Copy link
Copy Markdown
Contributor

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: failed

Thus the PR was not passing and not merged.

@conda-forge-curator conda-forge-curator Bot removed the automerge Merge the PR when CI passes label Sep 30, 2025
@conda-forge-admin
Copy link
Copy Markdown
Contributor

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@conda-forge-admin
Copy link
Copy Markdown
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint --conda-forge . from the recipe directory. You can also examine the workflow logs for more detail.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/18133229484. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Copy Markdown
Contributor

conda-forge-admin commented Sep 30, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/18136091716. Examine the logs at this URL for more detail.

@isuruf isuruf added the automerge Merge the PR when CI passes label Sep 30, 2025
@conda-forge-curator conda-forge-curator Bot removed the automerge Merge the PR when CI passes label Sep 30, 2025
@conda-forge-admin
Copy link
Copy Markdown
Contributor

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

@isuruf isuruf merged commit badb979 into conda-forge:main Sep 30, 2025
9 checks passed
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 21.1.2_hb35c82 branch September 30, 2025 16:41
Copy link
Copy Markdown
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for fixing this! Just one question

Comment thread recipe/meta.yaml
- test -f $PREFIX/include/omp.h # [unix]
- if not exist %LIBRARY_INC%\omp.h exit 1 # [win]
# clang-specific one (symlink on unix; copies on win, see install_pkg.bat)
- test -f $PREFIX/lib/clang/{{ clang_major }}/include/omp.h # [unix]
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you delete this test? It ensures that the header is where clang expects it?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have clang-{{ clang_major }} in the test environment.

Comment thread recipe/meta.yaml
- clangxx <={{ version }}
- clang-{{ clang_test_version }}
- {{ compiler('cxx') }}
- ld64 # [osx]
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably delete this one again.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants