Skip to content

Remove dependence on clang#91

Merged
isuruf merged 2 commits into
conda-forge:mainfrom
isuruf:clang-dep
Sep 29, 2025
Merged

Remove dependence on clang#91
isuruf merged 2 commits into
conda-forge:mainfrom
isuruf:clang-dep

Conversation

@isuruf
Copy link
Copy Markdown
Member

@isuruf isuruf commented Sep 29, 2025

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-admin
Copy link
Copy Markdown
Contributor

conda-forge-admin commented Sep 29, 2025

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

h-vetinari
h-vetinari approved these changes Sep 29, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect this might have something to do with my question in conda-forge/openmp-feedstock#189? Could you confirm or correct me? In any case, this looks reasonable to me, thanks!

Comment thread recipe/build.sh
Comment on lines +9 to +12
if [[ ! -f ${CXX} ]]; then
# Remove after https://github.com/conda-forge/clangdev-feedstock/pull/387 is in
ln -sf ${CC} ${CXX}
fi
Copy link
Copy Markdown
Member

@h-vetinari h-vetinari Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we wait for conda-forge/clangdev-feedstock#387 with this?

Copy link
Copy Markdown
Member Author

@isuruf isuruf Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can merge this for now. It'll be a no-op once that PR is in

@isuruf
Copy link
Copy Markdown
Member Author

isuruf commented Sep 29, 2025

I suspect this might have something to do with my question in conda-forge/openmp-feedstock#189?

Yes, that + github.com/conda-forge/conda-forge.github.io/issues/2595

@isuruf isuruf merged commit d37a0b4 into conda-forge:main Sep 29, 2025
21 checks passed
@isuruf isuruf mentioned this pull request Oct 6, 2025
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@h-vetinari h-vetinari h-vetinari approved these changes

@davidbrochart davidbrochart Awaiting requested review from davidbrochart davidbrochart is a code owner

@katietz katietz Awaiting requested review from katietz katietz is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@isuruf @conda-forge-admin @h-vetinari