Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild for CFEP-25 noarch: python syntax #4

Merged
merged 5 commits into from
Dec 17, 2024
Merged

Rebuild for CFEP-25 noarch: python syntax #4

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
da1729b
update to CFEP-25 `noarch: python` syntax
regro-cf-autotick-bot Dec 15, 2024
90d8c50
MNT: Re-rendered with conda-build 24.11.2, conda-smithy 3.45.0, and c…
regro-cf-autotick-bot Dec 15, 2024
5966662
bumpy min_python to 3.10 (Update .ci_support/linux_64_.yaml)
orbeckst Dec 16, 2024
121a9dc
undo change to 3.10 in .ci_support/linux_64_.yaml
orbeckst Dec 16, 2024
1153272
set python_min = 3.10 in meta.yaml
orbeckst Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .ci_support/linux_64_.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,7 @@ channel_targets:
- conda-forge main
docker_image:
- quay.io/condaforge/linux-anvil-x86_64:alma9
python_min:
- '3.9'
target_platform:
- linux-64
12 changes: 6 additions & 6 deletions recipe/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@ package:
version: {{ version }}

source:
url: https://pypi.io/packages/source/{{ name[0] }}/{{ name }}/{{ name }}-{{ version }}.tar.gz
url: https://pypi.org/packages/source/{{ name[0] }}/{{ name }}/{{ name }}-{{ version }}.tar.gz
sha256: 39150588b9bc07ebc176bac30d9c3b0bd25003e2e2eac24b622f2a10e5352a1f

build:
number: 0
number: 1

test:
imports:
Expand All @@ -27,22 +27,22 @@ outputs:
noarch: python
requirements:
host:
- python >=3.9
- python {{ python_min }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- python {{ python_min }}
- python >=3.10

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, reading through CFEP-25 I'm not sure I understand the logic of requiring the minimum version on the host? 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See discussion below.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT the discussion is on updating the python_min pin, but the bot PR here and elsewhere removes the >= in favour of just requiring the minimum version -- I don't understand this (unless I've misunderstood the syntax).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment in the main PR thread: for another PR, this was set to >= so the bot is doing something odd.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops... ^h^h ... the change that I referred to was in run and not in host: there it is also pinned to python {{ python_min }}.

- setuptools >=40.9.0
- wheel
- pip
run:
- python >=3.9
- python >={{ python_min }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- python >={{ python_min }}
- python >=3.10

- MDAnalysis >=2.0.0
- numpy >=1.22.3
- name: mdahole2
build:
noarch: python
requirements:
host:
- python >=3.9
- python {{ python_min }}
run:
- python >=3.9
- python >={{ python_min }}
- hole2
- {{ pin_subpackage('mdahole2-base', exact=True) }}

Expand Down
Loading