Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential fix for invalidation crashes #14

Merged
merged 2 commits into from
Nov 16, 2020
Merged

Potential fix for invalidation crashes #14

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f0d651
Potential fix for invalidation crashes
JosephDuffy Nov 3, 2020
f14dd9f
Comment why `layoutIsNeeded` is called
JosephDuffy Nov 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions Sources/ComposedUI/CollectionView/CollectionCoordinator.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,14 @@ extension CollectionCoordinator: SectionProviderMappingDelegate {
public func mappingWillBeginUpdating(_ mapping: SectionProviderMapping) {
reset()
defersUpdate = true

// This is called here to ensure that the collection view's internal state is in-sync with the state of the
// data in hierarchy of sections. If this is not done it can cause various crashes when `performBatchUpdates` is called
// due to the collection view requesting data for sections that no longer exist, or crashes because the collection view is
// told to delete/insert from/into sections that it does not yet think exist.
//
// For more information on this see https://github.com/composed-swift/ComposedUI/pull/14
collectionView.layoutIfNeeded()
shaps80 marked this conversation as resolved.
Show resolved Hide resolved
}

public func mappingDidEndUpdating(_ mapping: SectionProviderMapping) {
Expand Down