Potential fix for invalidation crashes #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As mentioned in #13 and #8 there are some scenarios where the collection view’s data is out-of-sync with the data in composed. As mentioned in #13 calling `layoutIfNeeded` can trigger the data to be in sync again. In this I have added it to `mappingWillBeginUpdating(_:)` which _appears_ to solve the problem. It might be needed in `replace(sectionProvider:)` (because `reloadData` is called) and/or `mappingDidInvalidate(_:)` (for the same reason) but I’m still investigating.
shaps80
reviewed
Nov 3, 2020
|
I've been using this in an app that performs a lot of updates. Animations are working and it doesn't crash any more. Hopefully this was the last crash with the layout (assuming no misuse) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #13 and #8 there are some scenarios where the collection view’s data is out-of-sync with the data in composed.
As mentioned in #13 calling
layoutIfNeededcan trigger the data to be in sync again. In this I have added it tomappingWillBeginUpdating(_:)which appears to solve the problem.It might be needed in
replace(sectionProvider:)(becausereloadDatais called) and/ormappingDidInvalidate(_:)(for the same reason) but I’m still investigating.I have validated this fix against #8 and it fixes the crash.
#13 still needs to be investigated and may require
layoutIfNeededto be called inmappingDidInvalidate. Marking as a draft until this is checked.