CLDC-3344: Sales CSV download ecstat2 child label bug fix

app/models/derived_variables/sales_log_variables.rb

@@ -160,6 +160,8 @@ def child_under_16_constraints!
     (start_index..6).each do |idx|
       if age_under_16?(idx)
         self["ecstat#{idx}"] = 9
+      elsif self["ecstat#{idx}"] == 9
+        self["ecstat#{idx}"] = nil
       end
     end
   end

app/models/form/sales/questions/buyer2_working_situation.rb

@@ -15,6 +15,10 @@ def initialize(id, hsh, page)
     @question_number = QUESTION_NUMBER_FROM_YEAR[form.start_date.year] || QUESTION_NUMBER_FROM_YEAR[QUESTION_NUMBER_FROM_YEAR.keys.max]
   end
 
+  def displayed_answer_options(log, _user = nil)
+    answer_options.reject { |key, _| key == "9" }
+  end
+
   def answer_options
     if form.start_year_2025_or_later?
       {
@@ -26,6 +30,7 @@ def answer_options
         "6" => { "value" => "Not seeking work" },
         "7" => { "value" => "Full-time student" },
         "8" => { "value" => "Unable to work due to long term sick or disability" },
+        "9" => { "value" => "Child under 16" },
         "0" => { "value" => "Other" },
         "10" => { "value" => "Buyer prefers not to say" },
       }.freeze
@@ -41,6 +46,7 @@ def answer_options
         "0" => { "value" => "Other" },
         "10" => { "value" => "Buyer prefers not to say" },
         "7" => { "value" => "Full-time student" },
+        "9" => { "value" => "Child under 16" },
       }.freeze
     end
   end

spec/models/form/sales/questions/buyer2_working_situation_spec.rb

@@ -36,22 +36,46 @@
       "0" => { "value" => "Other" },
       "10" => { "value" => "Buyer prefers not to say" },
       "7" => { "value" => "Full-time student" },
+      "9" => { "value" => "Child under 16" },
+    })
+  end
+
+  it "has the correct displayed_answer_options" do
+    expect(question.displayed_answer_options(nil)).to eq({
+      "1" => { "value" => "Full-time - 30 hours or more" },
+      "2" => { "value" => "Part-time - Less than 30 hours" },
+      "3" => { "value" => "In government training into work" },
+      "4" => { "value" => "Jobseeker" },
+      "6" => { "value" => "Not seeking work" },
+      "8" => { "value" => "Unable to work due to long term sick or disability" },
+      "5" => { "value" => "Retired" },
+      "0" => { "value" => "Other" },
+      "10" => { "value" => "Buyer prefers not to say" },
+      "7" => { "value" => "Full-time student" },
     })
   end
 
   context "with start year before 2025" do
     let(:form) { instance_double(Form, start_date: Time.zone.local(2024, 4, 1), start_year_2025_or_later?: false) }
 
     it "uses the old ordering for answer options" do
-      expect(question.answer_options.keys).to eq(%w[1 2 3 4 6 8 5 0 10 7])
+      expect(question.answer_options.keys).to eq(%w[1 2 3 4 6 8 5 0 10 7 9])
+    end
+
+    it "uses the old ordering for displayed answer options" do
+      expect(question.displayed_answer_options(nil).keys).to eq(%w[1 2 3 4 6 8 5 0 10 7])
     end
   end
 
   context "with start year from 2025" do
     let(:form) { instance_double(Form, start_date: Time.zone.local(2025, 4, 1), start_year_2025_or_later?: true) }
 
     it "uses the new ordering for answer options" do
-      expect(question.answer_options.keys).to eq(%w[1 2 3 4 5 6 7 8 0 10])
+      expect(question.answer_options.keys).to eq(%w[1 2 3 4 5 6 7 8 9 0 10])
+    end
+
+    it "uses the new ordering for displayed answer options" do
+      expect(question.displayed_answer_options(nil).keys).to eq(%w[1 2 3 4 5 6 7 8 0 10])
     end
   end
 

spec/models/sales_log_spec.rb

@@ -978,5 +978,54 @@ def previous_postcode_fields
       end
     end
   end
+
+  describe "#child_under_16_constraints!" do
+    let(:sales_log) { create(:sales_log, saledate: Time.zone.local(2024, 4, 1)) }
+
+    it "sets ecstat2 to 9 when age2 is under 16" do
+      sales_log.age2 = 14
+      sales_log.set_derived_fields!
+      expect(sales_log.ecstat2).to eq(9)
+    end
+
+    it "does not clear ecstat2 if it is not 9" do
+      sales_log.age2 = 22
+      sales_log.ecstat2 = 3
+      sales_log.set_derived_fields!
+      expect(sales_log.ecstat2).to eq(3)
+    end
+
+    it "clears ecstat3 if it is 9 and age3 is not under 16" do
+      sales_log.age3 = 22
+      sales_log.ecstat3 = 9
+      sales_log.set_derived_fields!
+      expect(sales_log.ecstat3).to be_nil
+    end
+
+    it "does not clear ecstat3 if it is not 9" do
+      sales_log.age3 = 22
+      sales_log.ecstat3 = 8
+      sales_log.set_derived_fields!
+      expect(sales_log.ecstat3).to eq(8)
+    end
+
+    context "when a user changes their answer" do
+      before do
+        sales_log.age2 = 14
+        sales_log.ecstat2 = 9
+      end
+
+      it "clears the working situation only when no longer a child under 16 and retains the new value" do
+        sales_log.set_derived_fields!
+        expect(sales_log.ecstat2).to eq(9)
+        sales_log.age2 = 22
+        sales_log.set_derived_fields!
+        expect(sales_log.ecstat2).to be_nil
+        sales_log.ecstat2 = 4
+        sales_log.set_derived_fields!
+        expect(sales_log.ecstat2).to eq(4)
+      end
+    end
+  end
 end
 # rubocop:enable RSpec/MessageChain