CLDC-3344: Sales CSV download ecstat2 child label bug fix #2801
Conversation
…r 16 without being blocked
| (start_index..6).each do |idx| | ||
| if age_under_16?(idx) | ||
| self["ecstat#{idx}"] = 9 | ||
| elsif self["ecstat#{idx}"] == 9 | ||
| self["ecstat#{idx}"] = nil | ||
| end | ||
| end |
There was a problem hiding this comment.
I've added this so a user can change the age of a person that was first set as under 16 to another age above 16. At the moment should they want to do that they would get an error:
Answer cannot be over 16 as person’s 2 working situation is ‘child under 16‘.
As the working situation question for a child is not one they can access they'd get stuck. Now should they change the age e.g. to 17, the next question will be to choose the working situation.
There was a problem hiding this comment.
Can we add some tests for this to make sure it doesn't clear it when we don't want it to?
|
Created review app at https://review.submit-social-housing-data.communities.gov.uk/2801 |
| "9" => { | ||
| "value" => "Child under 16", | ||
| "depends_on" => [ | ||
| { "saledate" => { "operator" => "<", "operand" => Time.zone.local(2024, 4, 1) } }, |
There was a problem hiding this comment.
If form.start_year_2025_or_later? the saledate can't be before 2024?
Maybe it's worth having answer_options and displayed_answer_options as we do on some other questions?
| "6" => { "value" => "Not seeking work" }, | ||
| "7" => { "value" => "Full-time student" }, | ||
| "8" => { "value" => "Unable to work due to long term sick or disability" }, | ||
| "9" => { "value" => "Child under 16" }, | ||
| "0" => { "value" => "Other" }, | ||
| "10" => { "value" => "Buyer prefers not to say" }, | ||
| }.freeze |
There was a problem hiding this comment.
Since we are not displaying the key “9” in 2024 or beyond, I added the value but omitted the depends_on conditions found on the generic person working situation page's answer options.
…ersion-2-ecstat-child # Conflicts: # spec/models/sales_log_spec.rb
…ersion-2-ecstat-child
…ersion-2-ecstat-child
Dinssa
deleted the
CLDC-3344-Sales-csv-download-label-bug-for-persion-2-ecstat-child
branch
We had a bug where instead of the user friendly label to explain what is meant when
ecstat2 = 9the value itself was returned in CSV downloads, unlike how it should appear (look toecstat3).This bug only appears on person 2's working situation question (
ecstat2) and only for when the value is9as the matching key-value pair in the answer options was missing. But was present on the generic working situation question for all people from person3, person4....onwards.Result:
