Skip to content

Preserve checkpoint upload timeout in DCP saves #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
haraschax wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Preserve checkpoint upload timeout in DCP saves #87

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions torchtitan/components/checkpoint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,7 +540,6 @@ def dcp_save(
ret: Future | AsyncSaveResponse | None = None

storage_writer: StorageWriter | None = None
checkpoint_save_id: str | None = None
fqn_to_index_mapping: dict[Any, int] | None = None

# HF Format Conversion
Expand All @@ -567,21 +566,17 @@ def dcp_save(
else:
storage_writer = FsspecWriter(checkpoint_id, timeout=CHECKPOINT_UPLOAD_TIMEOUT_SECONDS)

# Execution Dispatch
checkpoint_save_id = None if to_hf else checkpoint_id # for HF the storage_writer handles the path

# The writer owns the path. Passing checkpoint_id again resets fsspec options.
if async_mode == AsyncMode.ASYNC:
ret = dcp.async_save(
state_dict,
storage_writer=storage_writer,
checkpoint_id=checkpoint_save_id,
process_group=self.pg,
)
elif async_mode == AsyncMode.ASYNC_WITH_PINNED_MEM:
ret = dcp.async_save(
state_dict,
storage_writer=storage_writer,
checkpoint_id=checkpoint_save_id,
process_group=self.pg,
async_checkpointer_type=AsyncCheckpointerType.PROCESS,
async_stager=self.stager,
Expand All @@ -590,7 +585,6 @@ def dcp_save(
ret = dcp.save(
state_dict,
storage_writer=storage_writer,
checkpoint_id=checkpoint_save_id,
)

# Post-Processing
Expand Down
Loading