Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reapply "bump msgq (#34410)" #34443

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Reapply "bump msgq (#34410)" #34443

merged 2 commits into from
Jan 22, 2025

Conversation

sshane
Copy link
Contributor

@sshane sshane commented Jan 22, 2025 •
edited
Loading

Redo of #34410

Need to ignore EINTR

I was wondering why we needed this for #32103, because if msgq receives a termination signal, it will just set do_exit for us. However, this never worked because:

  • manager sends kill signal to all processes in series (almost parallel)
  • card gets SIGINT first and stops sending sendcan to pandad before pandad gets SIGINT
    • so now we're in the 100ms msgq recv timeout + msgq signal handler. pandad thus sees the SIGINT 50-100ms later than it's delivered, and this time without sendcan is enough to fault the car

@sshane sshane merged commit 45903ad into master Jan 22, 2025
20 of 21 checks passed
@sshane sshane deleted the bump-msgq branch January 22, 2025 00:34
sshane added a commit that referenced this pull request Jan 22, 2025
@sshane
Revert "Reapply "bump msgq (#34410)" (#34443)"
cb6eb4f 
This reverts commit 45903ad.
sshane added a commit that referenced this pull request Jan 22, 2025
@sshane
Reapply "Reapply "bump msgq (#34410)" (#34443)"
751bfd8 
This reverts commit cb6eb4f.
@sshane sshane mentioned this pull request Jan 22, 2025
Merged
sshane added a commit that referenced this pull request Jan 22, 2025
@sshane
bump msgq (#34445)
475c9ba 
* Reapply "Reapply "bump msgq (#34410)" (#34443)"

This reverts commit cb6eb4f.

* here too

* running locally in loop to make sure this was fluke

* running locally in loop to make sure this was fluke
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sshane