Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Github templates #439

Merged
merged 6 commits into from
Oct 16, 2023
Merged

Simplify Github templates #439

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
eddd179
Remove unnecessary horizontal lines
timbot1789 Oct 5, 2023
f62f8c9
Remove affected files section
timbot1789 Oct 6, 2023
abcb115
Remove the Desktop / Smartphone section from bug reports
timbot1789 Oct 6, 2023
46549bd
Merge branch 'Development' into update-github-templates
timbot1789 Oct 14, 2023
ab46643
remove actual behavior section
timbot1789 Oct 14, 2023
9b62803
respond to Jared's request
timbot1789 Oct 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 0 additions & 23 deletions .github/ISSUE_TEMPLATE/bug_report.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,54 +1,31 @@
---
name: Bug report
about: Create a report to help us improve
title: ''
labels: ''
assignees: ''

---

### Bug Title:
Please provide a CONCISE description of the bug.

---
### Bug Description:
Please provide a DETAILED description of the bug.

---
### Reproduction Steps:
**1.**
**2.** If needed, delete if not
**3.** If needed, delete if not

---
### Expected Behavior:
What should have happened if the bug didn't occur.

---
### Actual Behavior:
timbot1789 marked this conversation as resolved.
Show resolved Hide resolved
What actually happened, and how it differed from the expected behavior.

---
### Screenshots (If applicable):
If possible, add screenshots to help explain the problem.

---
### Desktop (please complete the following information):
Copy link
Contributor Author

@timbot1789 timbot1789 Oct 6, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need these two sections. Right now, PASS is purely a browser application, so the desktop/smartphone fields aren't useful to our bug reports. The only thing that matters is the browser, and the only browser we support is the most recent version of chromium. Any bug report that isn't on the most recent version of chromium is immediately invalid.

If that changes, we can add this section back in with the configurations we support.

- OS: [e.g. iOS]
- Browser [e.g. chrome, safari]
- Version [e.g. 22]

---
### Smartphone (please complete the following information):
- Device: [e.g. iPhone6]
- OS: [e.g. iOS8.1]
- Browser [e.g. stock browser, safari]
- Version [e.g. 22]

---
### Additional Context (optional):
Add any other context about the problem here.

---
### Possible Solution (optional):
If you have a suggestion on how to fix this bug.
6 changes: 0 additions & 6 deletions .github/ISSUE_TEMPLATE/enhancement_request.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,27 +1,21 @@
---
name: Enhancement request
about: Suggest an enhancement for this project
title: 'Enhancement: [Your Title Here]'
labels: enhancement
assignees: ''

---

### Describe the Current Behavior/Feature:
Provide a clear and concise description of the current behavior or feature.

---
### Proposed Behavior/Feature:
A clear and concise description of the enhancement you want.

---
### Rationale:
Please outline why this enhancement is needed and how it will benefit the project.

---
### Proposed Implementation (if applicable):
Provide a detailed low level description of how you propose the enhancement should be implemented.

---
### Additional context:
Add any other context or screenshots about the enhancement request here.
8 changes: 0 additions & 8 deletions .github/ISSUE_TEMPLATE/feature_request.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,36 +1,28 @@
---
name: Feature request
about: Suggest an idea for this project
title: ''
labels: ''
assignees: ''

---


### Feature Title:
Please provide a CONCISE description of the proposed feature.

---
### Feature Description:
Please provide a DETAILED description of the proposed feature.

---
### Use Case:
Explain when and why this feature would be used. Try to include as much detail as possible.

---
### Proposed Solution:
If you have a solution in mind, please outline it here.

---
### Alternative Solutions:
If there are alternative ways to solve this problem, please list them here.

---
### Screenshots (if applicable):
Include any screenshots that may be helpful.

---
### Additional Context:
Please provide any other information that might be helpful.
21 changes: 1 addition & 20 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,39 +1,20 @@
## CONCISE description of PR (PR Title)

---
## This PR:
Resolves #(put issue number here to link this PR to it)

**1.**
**2.** If needed, delete if not
**3.** If needed, delete if not

---
## The files this PR effects:

### Components
List file names here

### Tests
List file names here

### Other Files
List file names here

---
## Screenshots (if applicable):
Add any screenshots/videos here.

---
## Additional Context (optional):
Add any other context about the PR here.

---
## Future Steps/PRs Needed to Finish This Work (optional):
Add any other steps/PRs that may be needed to continue this work if this PR is just a step in the right direction.

---
## Issues needing discussion/feedback (optional):
**1.**
**2.** If needed, delete if not
**3.** If needed, delete if not
**3.** If needed, delete if not