-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify Github templates #439
Conversation
### Screenshots (If applicable): | ||
If possible, add screenshots to help explain the problem. | ||
|
||
--- | ||
### Desktop (please complete the following information): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need these two sections. Right now, PASS is purely a browser application, so the desktop/smartphone fields aren't useful to our bug reports. The only thing that matters is the browser, and the only browser we support is the most recent version of chromium. Any bug report that isn't on the most recent version of chromium is immediately invalid.
If that changes, we can add this section back in with the configurations we support.
8108516
to
de37fff
Compare
e3c42bb
to
abcb115
Compare
@timbot1789 not sure if this is technically ready for review or not, but I'm still okay with getting rid of the lines. I also propose dropping the concise title sections - as we already type a title for the Issue or PR (we dropped it for PR template.) Maybe we also adjust the github auto-template stuff (whatever you want to call it) at the top of the files, or drop them too... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are fine with me. Scott and I were just talking about how these needed some attention so hopefully this help. I think we had even talked about removing the additional context section and just leaving the description as the one source to provided info. I also think we can safely remove the title headers since they are already the title of the issue once its created.
### Bug Title:
Please provide a CONCISE description of the bug.
and
### Feature Title:
Please provide a CONCISE description of the proposed feature.
@xscottxbrownx @Jared-Krajewski responded to all your comments. I think this is gtg. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
This PR:
I find the formatting of our github templates hard to read, and I notice no one is really ever filling it out. I want to remove some unnecessary/redundant sections. This description is my proposed PR template.
1.
2. If needed, delete if not
3. If needed, delete if not
Screenshots (if applicable):
Add any screenshots/videos here.
Additional Context (optional):
Add any other context about the PR here.
Future Steps/PRs Needed to Finish This Work (optional):
Add any other steps/PRs that may be needed to continue this work if this PR is just a step in the right direction.
Issues needing discussion/feedback (optional):
1.
2. If needed, delete if not
3. If needed, delete if not