fix(tmux): handle single-pane pane-state parsing#2365
Closed
code-yeongyu wants to merge 2 commits intodevfrom
Closed
fix(tmux): handle single-pane pane-state parsing#2365code-yeongyu wants to merge 2 commits intodevfrom
code-yeongyu wants to merge 2 commits intodevfrom
Conversation
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 3 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: The PR refactors tmux parsing logic into a well-tested dedicated parser, specifically fixing a bug where single-pane sessions were ignored. The logic is robust and addresses CRLF issues.
Owner
Author
|
Closing this PR as it has merge conflicts with dev branch and is outdated. Please rebase and reopen if still needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
list-panesstdout parsing into a dedicated pane state parser.pane_titleis empty.Testing
bun test src/features/tmux-subagent/bun run typecheckbun run buildSummary by cubic
Fixes tmux pane parsing for single-pane sessions and CRLF output by introducing a dedicated parser, preventing window state failures when pane_title is empty. Addresses Linear issue 2241.
Bug Fixes
Refactors
Written for commit 8b71559. Summary will update on new commits.