Skip to content

fix(tmux): handle single-pane pane-state parsing#2365

Open
code-yeongyu wants to merge 2 commits intodevfrom
fix/issue-2241
Open

fix(tmux): handle single-pane pane-state parsing#2365
code-yeongyu wants to merge 2 commits intodevfrom
fix/issue-2241

Conversation

@code-yeongyu
Copy link
Owner

@code-yeongyu code-yeongyu commented Mar 7, 2026

Summary

  • Extract tmux list-panes stdout parsing into a dedicated pane state parser.
  • Accept pane rows with 8 mandatory fields so single-pane sessions still parse when pane_title is empty.
  • Normalize CRLF line endings and add coverage for empty titles, CRLF output, and tab-containing titles.

Testing

  • bun test src/features/tmux-subagent/
  • bun run typecheck
  • bun run build

Summary by cubic

Fixes tmux pane parsing for single-pane sessions and CRLF output by introducing a dedicated parser, preventing window state failures when pane_title is empty. Addresses Linear issue 2241.

  • Bug Fixes

    • Accept pane rows with 8 mandatory fields (no trailing title) so single-pane sessions parse.
    • Normalize CRLF line endings to avoid dropping panes.
    • Preserve tabs inside pane titles.
  • Refactors

    • Extracted tmux list-panes parsing into pane-state-parser and integrated it into pane-state-querier.
    • Added unit tests for empty titles, CRLF output, and titles containing tabs.

Written for commit 8b71559. Summary will update on new commits.

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Auto-approved: The PR refactors tmux parsing logic into a well-tested dedicated parser, specifically fixing a bug where single-pane sessions were ignored. The logic is robust and addresses CRLF issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant