Skip to content

fix(tmux): handle single-pane pane-state parsing#2453

Merged
code-yeongyu merged 2 commits intodevfrom
fix/issue-2241-v2
Mar 11, 2026
Merged

fix(tmux): handle single-pane pane-state parsing#2453
code-yeongyu merged 2 commits intodevfrom
fix/issue-2241-v2

Conversation

@code-yeongyu
Copy link
Owner

@code-yeongyu code-yeongyu commented Mar 11, 2026

Summary

  • Recreate closed PR fix(tmux): handle single-pane pane-state parsing #2365 on top of current dev for Linear issue 2241.
  • Extract tmux list-panes stdout parsing into a dedicated pane-state-parser module.
  • Keep single-pane parsing rules covered for empty trailing titles, CRLF output, and tab-containing titles.

Testing

  • bun test src/features/tmux-subagent/pane-state-querier.test.ts
  • bun run typecheck
  • bun run build

Summary by cubic

Fixes tmux pane-state parsing for single-pane windows and normalizes list-panes output to prevent dropped panes and wrong layouts. Addresses Linear 2241 by introducing a dedicated parser used by the subagent.

  • Bug Fixes

    • Accepts single-pane output when tmux omits the trailing title field.
    • Handles CRLF line endings without dropping panes.
    • Preserves tabs inside pane titles.
  • Refactors

    • Extracted pane-state-parser to parse list-panes stdout and return window size plus panes.
    • Updated pane-state-querier to use the parser and simplified parsing logic with new tests.

Written for commit e1b59e3. Summary will update on new commits.

code-yeongyu and others added 2 commits March 11, 2026 17:55
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Auto-approved: The PR correctly refactors tmux parsing into a testable module, addressing specific edge cases like CRLF and single-pane output without changing the core window state logic.

@code-yeongyu code-yeongyu merged commit 836ce97 into dev Mar 11, 2026
8 checks passed
@code-yeongyu code-yeongyu deleted the fix/issue-2241-v2 branch March 11, 2026 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant