kvclient: log internal rangefeed errors if no handler is present #156300
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of cockroachdb#75610, I find myself occasionally suspicious that some behavior is the result of a failed rangefeed client. This log line may help diagnose such issues. Informs cockroachdb#75610 Release note: None
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
wenyihu6
approved these changes
Oct 27, 2025
|
bors r=wenyihu6 |
craig bot
pushed a commit
that referenced
this pull request
Oct 28, 2025
156300: kvclient: log internal rangefeed errors if no handler is present r=wenyihu6 a=stevendanna Because of #75610, I find myself occasionally suspicious that some behavior is the result of a failed rangefeed client. This log line may help diagnose such issues. Informs #75610 Release note: None Co-authored-by: Steven Danna <[email protected]>
|
Build failed: |
|
bors retry |
craig bot
pushed a commit
that referenced
this pull request
Oct 29, 2025
156300: kvclient: log internal rangefeed errors if no handler is present r=wenyihu6 a=stevendanna Because of #75610, I find myself occasionally suspicious that some behavior is the result of a failed rangefeed client. This log line may help diagnose such issues. Informs #75610 Release note: None Co-authored-by: Steven Danna <[email protected]>
|
Build failed: |
|
bors retry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of #75610, I find myself occasionally suspicious that some behavior is the result of a failed rangefeed client. This log line may help diagnose such issues.
Informs #75610
Release note: None