Skip to content

Commit 0397cc1

Browse files
craig[bot]stevendanna
andcommitted
Merge #156300
156300: kvclient: log internal rangefeed errors if no handler is present r=wenyihu6 a=stevendanna Because of #75610, I find myself occasionally suspicious that some behavior is the result of a failed rangefeed client. This log line may help diagnose such issues. Informs #75610 Release note: None Co-authored-by: Steven Danna <[email protected]>
2 parents 707486e + c1b20fb commit 0397cc1

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

pkg/kv/kvclient/rangefeed/rangefeed.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -396,9 +396,10 @@ func (f *RangeFeed) run(ctx context.Context, frontier span.Frontier, resumeWithF
396396
errors.HasType(err, &kvpb.MVCCHistoryMutationError{}) {
397397
if errCallback := f.onUnrecoverableError; errCallback != nil {
398398
errCallback(ctx, err)
399+
log.VEventf(ctx, 1, "exiting rangefeed due to internal error: %v", err)
400+
} else {
401+
log.Dev.Warningf(ctx, "exiting rangefeed because of internal error with no OnInternalError callback: %s", err.Error())
399402
}
400-
401-
log.VEventf(ctx, 1, "exiting rangefeed due to internal error: %v", err)
402403
return
403404
}
404405
if err != nil && ctx.Err() == nil && restartLogEvery.ShouldLog() {

0 commit comments

Comments
 (0)