Add back an invalid url to the invalid_urls() fixture #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retr0h
reviewed
Sep 1, 2018
test/conftest.py
Outdated
| @@ -263,4 +263,4 @@ def git_urls(): | |||
|
|
|||
| @pytest.fixture() | |||
| def invalid_urls(): | |||
| return [] | |||
| return ['not a valid URL'] | |||
There was a problem hiding this comment.
Can we make this a url, one that the regex does not match?
There was a problem hiding this comment.
I can't think of one which might not be supported. May be better to rename this fixture to invalid_strings and the test to something like test_parse_raises_on_invalid_string?
There was a problem hiding this comment.
ya, renaming it sounds good
(and change the commit message)
|
rad @jameshiew, looks like travis is failing. |
Oh looks like it's an issue with flake8 3.6. |
|
#19 fixes the issue, please rebase against master. |
This restores some coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores some coverage