Skip to content

Commit 16c4cef

Browse files
authored
Merge pull request #18 from jameshiew/fix-test-coverage
Add back an invalid url to the invalid_urls() fixture
2 parents d9768f5 + d5a9af5 commit 16c4cef

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

test/conftest.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -262,5 +262,5 @@ def git_urls():
262262

263263

264264
@pytest.fixture()
265-
def invalid_urls():
266-
return []
265+
def invalid_strings():
266+
return ['', 'not a valid URL']

test/test_parser.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,9 @@ def test_parse(git_urls):
4141
assert d['owner'] == result.owner
4242

4343

44-
def test_parse_raises_on_invalid_url(invalid_urls):
45-
for url in invalid_urls:
46-
p = parser.Parser(url)
44+
def test_parse_raises_on_invalid_string(invalid_strings):
45+
for invalid_string in invalid_strings:
46+
p = parser.Parser(invalid_string)
4747
with pytest.raises(parser.ParserError):
4848
p.parse()
4949

0 commit comments

Comments
 (0)