Skip to content

Minor etl LGAD Rotation fix #49957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leonardolanteri wants to merge 3 commits into
base: master
Choose a base branch
from
+17 −6
Open

Minor etl LGAD Rotation fix #49957

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
87f64aa
correct fix
leonardolanteri Jan 22, 2026
20f6d26
minor name fix
leonardolanteri Jan 28, 2026
b95f2c5
leaving etl v9 and v10 untouched
leonardolanteri Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions Geometry/MTDCommonData/data/etl/v11/etl.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
<?xml version="1.0"?>
<DDDefinition>


<RotationSection label="etl.xml">
<Rotation name="RPCD_plus_90CW" thetaX="90*deg" phiX="-90*deg" thetaY="90*deg" phiY="180*deg" thetaZ="180*deg" phiZ="0*deg"/>
</RotationSection>

<ConstantsSection label="etl.xml" eval="true">
<Constant name="ETL_thickness" value="([caloBase:Zpos0H]-[caloBase:Zpos10])"/>
Expand Down Expand Up @@ -952,11 +954,13 @@
<PosPart copyNumber="1">
<rParent name="etl:Half_Module_Front"/>
<rChild name="etl:LGAD"/>
<rRotation name="rotations:R270" />
<Translation x="-1*[LGAD_translation_x]" y="-1*[LGAD_translation_y]" z="[LGAD_translation_z]" />
</PosPart>
<PosPart copyNumber="2">
<rParent name="etl:Half_Module_Front"/>
<rChild name="etl:LGAD"/>
<rRotation name="rotations:R270" />
<Translation x="[LGAD_translation_x]" y="-1*[LGAD_translation_y]" z="[LGAD_translation_z]" />
</PosPart>

Expand Down Expand Up @@ -1151,13 +1155,15 @@
<PosPart copyNumber="1">
<rParent name="etl:Half_Module_Back"/>
<rChild name="etl:LGAD"/>
<rRotation name="rotations:RPCD" />
<!--<rRotation name="rotations:RPCD" /> -->
<rRotation name="etl:RPCD_plus_90CW" />
<Translation x="-1*[LGAD_translation_x]" y="-1*[LGAD_translation_y]" z="-1*[LGAD_translation_z]" />
</PosPart>
<PosPart copyNumber="2">
<rParent name="etl:Half_Module_Back"/>
<rChild name="etl:LGAD"/>
<rRotation name="rotations:RPCD" />
<!--<rRotation name="rotations:RPCD" /> -->
<rRotation name="etl:RPCD_plus_90CW" />
<Translation x="[LGAD_translation_x]" y="-1*[LGAD_translation_y]" z="-1*[LGAD_translation_z]" />
</PosPart>

Expand Down
11 changes: 8 additions & 3 deletions Geometry/MTDCommonData/data/etl/v12/etl.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
<?xml version="1.0"?>
<DDDefinition>


<RotationSection label="etl.xml">
<Rotation name="RPCD_plus_90CW" thetaX="90*deg" phiX="-90*deg" thetaY="90*deg" phiY="180*deg" thetaZ="180*deg" phiZ="0*deg"/>
</RotationSection>


<ConstantsSection label="etl.xml" eval="true">
Expand Down Expand Up @@ -951,11 +954,13 @@
<PosPart copyNumber="1">
<rParent name="etl:Half_Module_Front"/>
<rChild name="etl:LGAD"/>
<rRotation name="rotations:R270" />
<Translation x="-1*[LGAD_translation_x]" y="-1*[LGAD_translation_y]" z="[LGAD_translation_z]" />
</PosPart>
<PosPart copyNumber="2">
<rParent name="etl:Half_Module_Front"/>
<rChild name="etl:LGAD"/>
<rRotation name="rotations:R270" />
<Translation x="[LGAD_translation_x]" y="-1*[LGAD_translation_y]" z="[LGAD_translation_z]" />
</PosPart>

Expand Down Expand Up @@ -1150,13 +1155,13 @@
<PosPart copyNumber="1">
<rParent name="etl:Half_Module_Back"/>
<rChild name="etl:LGAD"/>
<rRotation name="rotations:RPCD" />
<rRotation name="etl:RPCD_plus_90CW" />
<Translation x="-1*[LGAD_translation_x]" y="-1*[LGAD_translation_y]" z="-1*[LGAD_translation_z]" />
</PosPart>
<PosPart copyNumber="2">
<rParent name="etl:Half_Module_Back"/>
<rChild name="etl:LGAD"/>
<rRotation name="rotations:RPCD" />
<rRotation name="etl:RPCD_plus_90CW" />
<Translation x="[LGAD_translation_x]" y="-1*[LGAD_translation_y]" z="-1*[LGAD_translation_z]" />
</PosPart>

Expand Down