-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Put back SiPixel Rechits GPU-vs-CPU validation in online DQM and GPU relvals #49937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Put back SiPixel Rechits GPU-vs-CPU validation in online DQM and GPU relvals #49937
Conversation
- possible after the merge of cms-sw#49928
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49937/47687
|
|
A new Pull Request was created by @mmusich for master. It involves the following packages:
@cmsbuild, @ctarricone, @gabrielmscampos, @nothingface0, @rseidita can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
enable gpu |
|
test parameters:
|
|
@cmsbuild, please test |
|
-1 Failed Tests: RelVals-NVIDIA_T4 Failed RelVals-NVIDIA_T4
Comparison SummaryThe workflows 2025.0010001, 2024.0060001, 2024.0050001 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons Summary:
Max Memory Comparisons exceeding threshold@cms-sw/core-l2 , I found 2 workflow step(s) with memory usage exceeding the error threshold: Expand to see workflows ...
|
all failures are due to #49795
changes are spurious, due to
|
|
ignore tests-rejected with ib-failure |
|
+dqm |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (test failures were overridden). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2) |
|
GPU tests are failing but I think this is expected at the moment. Waiting for confirmation before merging. |
@ftenchini yes, see #49937 (comment) |
|
+1 |
PR description:
Title says it all, possible after the merge of #49928 (see CMSHLT-3710 for more details) in which we have (re-)started to populate the
DQMGPUvsCPUstream with theSiPixelRecHitsSoA data-structures, thanks to the resolution of #49349 via #49432PR validation:
scram b runtests_TestDQMOnlineClient-pixelgpu_dqm_sourceclientruns fine after the updated.If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, it will be backported to
CMSSW_16_0_Xfor 2026 data-taking operations.